Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all remaining cilium-cli workflows to run using Helm mode #1625

Closed
asauber opened this issue May 12, 2023 · 4 comments
Closed

Migrate all remaining cilium-cli workflows to run using Helm mode #1625

asauber opened this issue May 12, 2023 · 4 comments
Assignees
Labels
kind/feature New feature or request

Comments

@asauber
Copy link
Member

asauber commented May 12, 2023

As part of the Cilium CLI Helm mode implementation, a variety of the CI workflows were updated to run both a Helm-based implementation and "classic" implementation.

https://github.com/cilium/cilium-cli/blob/main/.github/workflows/gke.yaml#L41
https://github.com/cilium/cilium-cli/blob/main/.github/workflows/multicluster.yaml#L42

One of these was the first CI usage of the cilium upgrade subcommand.

https://github.com/cilium/cilium-cli/blob/main/.github/workflows/kind.yaml#L226

The goal of this task is to migrate all of the remaining workflows to use the Helm mode, in preparation for Helm mode becoming the default mode in the next release of cilium-cli

@asauber asauber added the kind/feature New feature or request label May 12, 2023
@asauber asauber assigned asauber and unassigned asauber May 12, 2023
@michi-covalent michi-covalent self-assigned this May 16, 2023
michi-covalent added a commit that referenced this issue May 16, 2023
Ref: #1625

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit that referenced this issue May 16, 2023
michi-covalent added a commit that referenced this issue May 16, 2023
@michi-covalent
Copy link
Contributor

michi-covalent added a commit that referenced this issue May 17, 2023
Ref: #1625

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit that referenced this issue May 17, 2023
Ref: #1625

Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent added a commit that referenced this issue May 17, 2023
michi-covalent added a commit that referenced this issue May 18, 2023
michi-covalent added a commit that referenced this issue May 18, 2023
@asauber
Copy link
Member Author

asauber commented May 18, 2023

@michi-covalent multicluster was completed a while back 41d8616 🙂

@michi-covalent
Copy link
Contributor

oh wow things are moving at an amazing pace

michi-covalent added a commit that referenced this issue May 18, 2023
michi-covalent added a commit that referenced this issue May 18, 2023
michi-covalent added a commit that referenced this issue May 19, 2023
michi-covalent added a commit that referenced this issue May 19, 2023
@michi-covalent
Copy link
Contributor

completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants