connectivity: skip nodeport tests with clustermesh if KPR is disabled #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Global NodePort services are not supported when they are managed by iptables/ipvs, since they do not know about remote endpoints. Hence, let's skip the related connectivity tests when running in multicluster mode and KPR NodePort support is disabled, to prevent spurious failures. Related: cilium/cilium#23128 Related: cilium/cilium#23266 Fixes: cilium#1352 Signed-off-by: Marco Iorio <[email protected]>
2 tasks
tklauser
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global NodePort services are not supported when they are managed by iptables/ipvs, since they do not know about remote endpoints. Hence, let's skip the related connectivity tests when running in multicluster mode and KPR NodePort support is disabled, to prevent spurious failures.
Related: cilium/cilium#23128
Related: cilium/cilium#23266
Fixes: #1352