Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Only run multi-cluster global NodePort service tests if kpr is enabled #1352

Closed
jspaleta opened this issue Jan 25, 2023 · 0 comments · Fixed by #1401
Closed

Enhancement: Only run multi-cluster global NodePort service tests if kpr is enabled #1352

jspaleta opened this issue Jan 25, 2023 · 0 comments · Fixed by #1401
Labels
kind/feature New feature or request

Comments

@jspaleta
Copy link

jspaleta commented Jan 25, 2023 •
edited
Loading

Proposal / RFE

Discovered this during AKS multi-cluster guide validation...
global NodePort services only work as expected if cilium is replacing kube-proxy.
See comments in: cilium/cilium#23266

Is your feature request related to a problem?
This results in spurious connectivity test failures on multi-clusters with kube-proxy running, leads to bad experience for people running through the documented multi-cluster guided path.

Describe the solution you'd like
By default, auto-detect if kube-proxy replacement is enabled and if it is run the global NodePort service tests. If kube-proxy replacement is not active, skip this tests..as they are expected to fail.
@jspaleta jspaleta added the kind/feature New feature or request label Jan 25, 2023
giorio94 added a commit to giorio94/cilium-cli that referenced this issue Feb 17, 2023
@giorio94
connectivity: skip nodeport tests with clustermesh if KPR is disabled
52a438c 
Global NodePort services are not supported when they are managed by
iptables/ipvs, since they do not know about remote endpoints. Hence,
let's skip the related connectivity tests when running in multicluster
mode and KPR NodePort support is disabled, to prevent spurious failures.

Related: cilium/cilium#23128
Related: cilium/cilium#23266
Fixes: cilium#1352

Signed-off-by: Marco Iorio <[email protected]>
@giorio94 giorio94 mentioned this issue Feb 17, 2023
Merged
tklauser pushed a commit that referenced this issue Feb 21, 2023
@giorio94 @tklauser
connectivity: skip nodeport tests with clustermesh if KPR is disabled
756b7a2 
Global NodePort services are not supported when they are managed by
iptables/ipvs, since they do not know about remote endpoints. Hence,
let's skip the related connectivity tests when running in multicluster
mode and KPR NodePort support is disabled, to prevent spurious failures.

Related: cilium/cilium#23128
Related: cilium/cilium#23266
Fixes: #1352

Signed-off-by: Marco Iorio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

connectivity: skip nodeport tests with clustermesh if KPR is disabled giorio94/cilium-cli
1 participant
@jspaleta