Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1er borrador tidy data #70

Merged
merged 20 commits into from
Mar 19, 2019
Merged

1er borrador tidy data #70

merged 20 commits into from
Mar 19, 2019

Conversation

pachadotdev
Copy link
Member

No description provided.

@pachadotdev
Copy link
Member Author

@rivaquiroga esto está sin revisor

@rivaquiroga
Copy link
Member

Gracias @mpaulacaldas por participar en la revisión de este capítulo. Cualquier duda, puedes mirar el documento con las indicaciones generales para esta parte del proceso o consultar en el canal de Slack #dudas-revisión.

@pachadotdev
Copy link
Member Author

gracias @rivaquiroga y @mpaulacaldas
acabo de invitar a @mpaulacaldas a la organización para poder asignar review, etc

@mpaulacaldas
Copy link

Gracias @rivaquiroga y @pachamaltese! Les confirmo que ya tengo acceso a la organización, y esta noche comienzo con la revisión del capítulo.

@pachadotdev pachadotdev requested a review from mpaulacaldas March 6, 2019 13:29
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
tidy.Rmd Outdated Show resolved Hide resolved
table1
table2
table3
tabla1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Este comentario puede que no tenga importancia, pero veo que los tableros de datos tienen variables de factores, lo cual no es el caso en los datos de tidyr:

library(datos)
library(tidyr)
#> Warning: package 'tidyr' was built under R version 3.5.2

tidyr::table4a
#> # A tibble: 3 x 3
#>   country     `1999` `2000`
#> * <chr>        <int>  <int>
#> 1 Afghanistan    745   2666
#> 2 Brazil       37737  80488
#> 3 China       212258 213766
datos::tabla4a
#> # A tibble: 3 x 3
#>   pais       `1999` `2000`
#>   <fct>       <int>  <int>
#> 1 Afganistan    745   2666
#> 2 Brasil      37737  80488
#> 3 China      212258 213766

Created on 2019-03-07 by the reprex
package
(v0.2.0).

Los factores no afectan para nada las operaciones de este capítulo, pero no sé si ese pueda ser el caso en otros capítulos. Lo dejo aquí más como un FYI, pero no como sugerencia de corrección.

Copy link

@mpaulacaldas mpaulacaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dejé aquí mis comentarios sobre el capítulo.

Unos comentarios generales:

  • En varios lugares utilizas dataset. Creo que quedamos en conjunto de datos. Lo indiqué en ciertos lugares pero no en todos, entonces si decides cambiarlo quizás te queda mejor hacer una búsqueda general.
  • Idem para datos perdidos -> datos faltantes
  • Revisé los contenidos de los code chunks uno por uno pero no traté de producir el libro (problema de packrat), pero no creo que vayan a haber problemas en el knit.

¡No duden si quieren discutir!

@pachadotdev pachadotdev merged commit dff8bcd into cienciadedatos:traduccion Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants