Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to sentinel upload failures. #1094

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Add context to sentinel upload failures. #1094

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a2aebcb
Add context to sentinel upload failures.
jmhobbs Oct 10, 2024
d53e991
Use LTS version of Node
codykaup Oct 16, 2024
0d0f788
Move sentinel error messaging to external file.
jmhobbs Oct 17, 2024
8768fa4
Add story for sentinel file errors message
jmhobbs Oct 17, 2024
f4d4a94
Style link in sentinel file error
jmhobbs Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion node-src/tasks/upload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,15 @@ export const waitForSentinels = async (ctx: Context, task: Task) => {
})
);

await Promise.all(Object.values(sentinels).map((sentinel) => waitForSentinel(ctx, sentinel)));
try {
await Promise.all(Object.values(sentinels).map((sentinel) => waitForSentinel(ctx, sentinel)));
} catch (err) {
throw new Error(
`Failed to finalize upload. Please check https://status.chromatic.com/ or contact support.

${err.message}`
);
}
};

export default createTask({
Expand Down
Loading