Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to sentinel upload failures. #1094

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Oct 10, 2024

Adds useful information when a sentinel file check fails, which generally means there is a system outage.

Screenshot 2024-10-10 at 3 51 56 PM

Closes #1063

📦 Published PR as canary version: 11.13.1--canary.1094.11444006276.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@jmhobbs jmhobbs requested a review from a team October 10, 2024 20:55
@jmhobbs jmhobbs self-assigned this Oct 10, 2024
@jmhobbs jmhobbs added patch Auto: Increment the patch version when merged skip-release Auto: Preserve the current version when merged labels Oct 10, 2024
Copy link
Contributor

github-actions bot commented Oct 10, 2024

📦 Package Size: 5268 KB

Copy link

codacy-production bot commented Oct 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.03% (target: -1.00%) 45.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6890d08) 8460 4652 54.99%
Head commit (f4d4a94) 8479 (+19) 4660 (+8) 54.96% (-0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1094) 20 9 45.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

node-src/tasks/upload.ts Outdated Show resolved Hide resolved
@jmhobbs jmhobbs requested a review from codykaup October 17, 2024 15:19
@jmhobbs jmhobbs added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit f1bfdb4 Oct 17, 2024
20 of 21 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/cap-2266-misleading-error-during-downtime branch October 17, 2024 18:55
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.13.0 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading error during downtime
4 participants