Account for --exit-zero-on-changes=true
#1083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #973
If you pass something to
--exit-zero-on-changes
, the CLI assumes you're providing a branch name. However, if you pass--exit-zero-on-changes=true
, it assumestrue
is the branch and essentially breaks the flag (unless your branch is literallytrue
).To account for this, we can simply check if the
--exit-zero-on-changes
contains the string'true'
when we set the exit code on the snapshot step.📦 Published PR as canary version:
11.11.1--canary.1083.11219791549.0
✨ Test out this PR locally via: