Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--exit-zero-on-changes true flag does not change anything #973

Closed
ivanignatiev opened this issue May 2, 2024 · 1 comment · Fixed by #1083
Closed

--exit-zero-on-changes true flag does not change anything #973

ivanignatiev opened this issue May 2, 2024 · 1 comment · Fixed by #1083
Assignees
Labels
bug Classification: Something isn't working CLI

Comments

@ivanignatiev
Copy link

Bug report

I am launching npx chromatic inside Azure Pipelines with following arguments:

npx chromatic --exit-zero-on-changes true --debug true --ci true --no-interactive --log-file false --junit-report /home/vsts/work/1/junit_report-100.xml

but I am getting always the same error, exit code 1:

✖ Found 3 visual changes: Review the changes
ℹ For CI/CD use cases, this command failed with exit code 1
Pass --exit-zero-on-changes to succeed this command regardless of changes.
Pass --auto-accept-changes to succeed and automatically accept any changes.

jUnit report is saved to the correct file, so I suppose arguments are good.

I have tried to add chromatic.config.json with following content:

{
    "projectId": "Project:xxxx",
    "debug": true,
    "exitZeroOnChanges": true
}

but nothing changes, it is keeping to exit with 1.

Runtime:

{
 "nodePlatform": "linux",
 "nodeVersion": "18.20.2",
  "packageManager": "npm",
  "packageManagerVersion": "10.5.0"
}

Anybody have the same issue?

@ivanignatiev ivanignatiev added bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation labels May 2, 2024
@winkerVSbecks
Copy link
Member

Is the command generating the log file and junit-report? If not, then something's preventing the flags from passing into the chromatic command.

What happens when you run the command locally? Does it exit with zero?

@codykaup codykaup self-assigned this Oct 7, 2024
@codykaup codykaup added CLI and removed needs triage Tracking: Issue needs confirmation labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants