Fix occasional Hypothesis test failure when calling get_or_create_collection
#379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Hypothesis tests would occasionally fail when they stumbled on a scenario like the following:
This PR allows the tests to pass by not making the assertion in the special case of
metadata=None
.This cannot be fixed in code, because we have already designed passing
metadata=None
to mean "do not update the metadata." As such, there is no way to explicitly set the metadata to None without making user-facing API changes, and so the tests should not try to do so.Test plan
This fixes a failure in the existing tests.
Documentation Changes
N/A