Merge pull request #379 from chroma-core/lukev/fix-coll-upsert-failure

Fix occasional Hypothesis test failure when calling `get_or_create_collection`

chromadb/test/property/test_collections.py

@@ -90,7 +90,8 @@ def list_collections(self):
     def get_or_create_coll(self, coll):
         c = self.api.get_or_create_collection(**coll)
         assert c.name == coll["name"]
-        assert c.metadata == coll["metadata"]
+        if coll["metadata"] is not None:
+            assert c.metadata == coll["metadata"]
         self.existing.add(coll["name"])
         return coll
 
@@ -131,3 +132,11 @@ def test_upsert_metadata_example(api):
     v1 = state.create_coll(coll={"name": "E40", "metadata": None})
     state.get_or_create_coll(coll={"name": "E40", "metadata": {"foo": "bar"}})
     state.teardown()
+
+
+def test_create_coll_with_none_metadata(api):
+    coll = {"name": "foo", "metadata": None}
+    api.reset()
+    c = api.get_or_create_collection(**coll)
+    assert c.name == coll["name"]
+    assert c.metadata == coll["metadata"]