Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Does the integrity check work? #3392

Merged
merged 1 commit into from
Jan 2, 2025
Merged

[BUG] Does the integrity check work? #3392

merged 1 commit into from
Jan 2, 2025

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Jan 2, 2025

It does not seem to, comment out for now while we investigate.

@rescrv rescrv requested a review from Sicheng-Pan January 2, 2025 23:02
Copy link

github-actions bot commented Jan 2, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

It does not seem to, comment out for now while we investigate.
@rescrv rescrv merged commit f488d7d into main Jan 2, 2025
78 checks passed
@rescrv rescrv deleted the rescrv/integrity branch January 16, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant