Skip to content

Commit

Permalink
[BUG] Does the integrity check work? (#3392)
Browse files Browse the repository at this point in the history
It does not seem to, comment out for now while we investigate.
  • Loading branch information
rescrv authored Jan 2, 2025
1 parent 92152f1 commit f488d7d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion rust/index/bindings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ class Index
throw std::runtime_error("Index already inited");
}
appr_alg = new hnswlib::HierarchicalNSW<dist_t>(l2space, path_to_index, false, 0, allow_replace_deleted, normalize, is_persistent_index);
appr_alg->checkIntegrity();
// TODO(rescrv,sicheng): check integrity
// appr_alg->checkIntegrity();
index_inited = true;
}

Expand Down
3 changes: 3 additions & 0 deletions rust/index/src/hnsw.rs
Original file line number Diff line number Diff line change
Expand Up @@ -854,6 +854,9 @@ pub mod test {
}

#[test]
// TODO(rescrv,sicheng): This test should be re-enabled once we have a way to detect
// corruption.
#[ignore]
fn it_can_detect_corruption() {
let n = 1000;
let d: usize = 960;
Expand Down

0 comments on commit f488d7d

Please sign in to comment.