Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLD] Python & misc lint fixes #2046

Merged
merged 4 commits into from
Apr 24, 2024
Merged

[BLD] Python & misc lint fixes #2046

merged 4 commits into from
Apr 24, 2024

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Apr 23, 2024

This enables all lints except check-yamland mypy, both of which seem to require quite a few manual changes.

I'll create issues to enable those after merging this.

Outside of removing a few unused imports & the updates to the lint config/workflow, the changes in this PR were entirely made by automated tooling.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb force-pushed the fix-python-lint-issues branch from 916e420 to 12ededf Compare April 23, 2024 20:11
@codetheweb codetheweb marked this pull request as ready for review April 23, 2024 22:14
@codetheweb codetheweb force-pushed the fix-python-lint-issues branch from c0a023a to 8727ee7 Compare April 24, 2024 20:50
@codetheweb codetheweb merged commit 413174d into main Apr 24, 2024
121 checks passed
@codetheweb codetheweb deleted the fix-python-lint-issues branch April 24, 2024 21:55
This was referenced Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant