Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable check-yaml lint in CI #2053

Closed
codetheweb opened this issue Apr 24, 2024 · 0 comments · Fixed by #2078
Closed

Enable check-yaml lint in CI #2053

codetheweb opened this issue Apr 24, 2024 · 0 comments · Fixed by #2078
Labels
cleanup good first issue Good for newcomers

Comments

@codetheweb
Copy link
Contributor

I recently enabled most of our lints in CI: #2046.

I didn't enable check-yaml in that PR because it looked like it required a few manual changes to pass the lint. We need to enable this lint by updating .github/workflows/chroma-lint.yml and making the appropriate changes to pass the lint (test locally with pre-commit run --all-files check-yaml).
@codetheweb codetheweb added good first issue Good for newcomers cleanup labels Apr 24, 2024
@ibratoev ibratoev mentioned this issue Apr 29, 2024
Merged
beggers pushed a commit that referenced this issue Apr 30, 2024
@ibratoev
[ENH] Enable check-yaml in CI (#2078)
ff93ecd 
Exclude Helm templates from YAML linting as they are not valid YAML

Fixes #2053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ENH] Enable check-yaml in CI ibratoev/chroma
1 participant
@codetheweb