Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: CIP-2 Auth Providers - Clean-up #1025

Merged
merged 4 commits into from
Aug 23, 2023
Merged

[BUG]: CIP-2 Auth Providers - Clean-up #1025

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb999d4
fix: CIP-2 Auth Providers
tazarov Aug 23, 2023
82c3aa6
chore: CIP-2 Auth Providers
tazarov Aug 23, 2023
dd3af5d
fix: CIP-2 Auth Providers
tazarov Aug 23, 2023
e336b0a
chore: CIP-2 Auth Providers
tazarov Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chromadb/auth/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import importlib
import logging
import pkgutil
from typing import Union, Dict, Type, Callable
from typing import Union, Dict, Type, Callable # noqa: F401

from chromadb.auth import (
ClientAuthConfigurationProvider,
Expand Down Expand Up @@ -47,7 +47,7 @@ def register_provider(
short_hand: str,
) -> Callable[[Type[ProviderTypes]], Type[ProviderTypes]]:
def decorator(cls: Type[ProviderTypes]) -> Type[ProviderTypes]:
logger.error("Registering provider: %s", short_hand)
logger.debug("Registering provider: %s", short_hand)
global _provider_registry
if issubclass(cls, ClientAuthProvider):
_provider_registry["client_auth_providers"][short_hand] = cls
Expand Down
2 changes: 2 additions & 0 deletions chromadb/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ def chroma_server_auth_credentials_file_non_empty_file_exists(
"/api/v1": ["GET"],
"/api/v1/heartbeat": ["GET"],
"/api/v1/version": ["GET"],
"/docs": ["GET"],
tazarov marked this conversation as resolved.
Show resolved Hide resolved
"/openapi.json": ["GET"],
}

chroma_client_auth_credentials_provider: Optional[
Expand Down
2 changes: 1 addition & 1 deletion docs/CIP_2_Auth_Providers_Proposal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Status

Current Status: `Under Discussion`
Current Status: `Accepted`

## **Motivation**

Expand Down