[BUG]: CIP-2 Auth Providers - Clean-up #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated logger level
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
- Set the status of the CIP to `Accepted`
tazarov
changed the title
- Adding /docs and /openapi.json the the ignore paths - by default leaving the API interface public
HammadB
reviewed
Aug 23, 2023
- Removing /docs and /openapi.json from ignored auth paths
HammadB
approved these changes
Aug 23, 2023
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this pull request
Aug 30, 2023
- Updated logger level to avoid confusion ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Changed logger level message when registering new Auth providers to debug to avoid confusing developers. - Change the status of the CIP to `Accepted` - Added `/docs` and `/openapi.json` to the publicly accessible endpoints (this may or many not be a security concern - TBD) ## Test plan Local tests are passing—no new tests. ## Documentation Changes N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Accepted/docsand/openapi.jsonto the publicly accessible endpoints (this may or many not be a security concern - TBD)Test plan
Local tests are passing—no new tests.
Documentation Changes
N/A