Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): remove list optimisation text #516

Closed
wants to merge 1 commit into from
Closed

docs(README): remove list optimisation text #516

wants to merge 1 commit into from

Conversation

varjmes
Copy link
Contributor

@varjmes varjmes commented Jun 21, 2017

✨ ✨ ✨

Lists have been optimised via choojs/nanomorph#8 in v5.0.0
I've removed the text.

It may be that you still want to explain list reordering optimisations using nanomorph. If so, you can mash that close button and write up an explanation 📝

Ty for choo! 🚂

✨ ✨ ✨

@yoshuawuyts
Copy link
Member

Haha, hey! Happy to see you here! 😁 - umm, so the thing is that nanomorph v5 is currently a lil broken (oops); work is being done in choojs/nanomorph#71 to fix it. That's why it's not part of any of the choo releases yet, and why that notice was still there haha.

That patch is one of two holding up the choo v6 release (see #489 for progress); the other patch is redoing choojs/nanohtml#77 to fix whitespace issues in the v4 line (also not shipped into choo yet).

Hope this makes sense haha ✨ - you're right in that we should write an explanation on how child reordering works tho; on the choo 6 branch I don't think we have written that yet. If you're keen a PR would be rad.

Anyway, yay thanks for the PR!

@varjmes
Copy link
Contributor Author

varjmes commented Jun 21, 2017

I would have no idea what to write! So I will not be able to 😂

Thanks yosh~

@varjmes varjmes closed this Jun 21, 2017
@varjmes varjmes deleted the patch-1 branch June 21, 2017 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants