-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6 beta branch #489
v6 beta branch #489
Conversation
Timing API has been upgraded, now shows separate timings for creating DOM trees + morphing the trees. I'm not sure about the event names tho; right now they are: choo.render:view.route # for choo's internal stuff
choo.emitter:foo:bar # for an event a user registers What I'm wondering is if we should perhaps upgrade nanobus to delimit internal events with a choo:render/view:route # for choo's internal stuff
choo:emitter/foo:bar # for an event a user registers Thoughts? cc/ @juliangruber @timwis |
note to self: move the new choo |
thoughts:
|
i like the following proposals by @juliangruber
|
@juliangruber gonna try some of those out; like the edit: The syntax to create timings internally is: var nanotiming = require('nanotiming')
var nanobus = require('nanobus')
var timing = nanotiming('choo')
var uuid = timing.start('render')
timing.end(uuid, 'render')
var timing = nanotiming('choo')
var name = "route['" + '/' + "']"
var uuid = timing.start(name)
timing.end(uuid, name)
var emitter = nanobus('choo.emit')
emitter.emit('log:debug') So this leaves us somewhat constrained in our display options. I'm thinking naming like this might be neat: choo(render) [12356778]
choo(route['/']) [13355671]
choo.emit('log:debug') [13355675] The weird tailing numbers are unique UUIDs because turns out we need them if we wanna keep tracing stuff. The output for |
Also thinking of adding a edit: also expose the route name as |
81c934b
to
f3de632
Compare
Is there any reason for |
@tornqvist I think what you're proposing makes sense (: |
fc197bc
to
57480f4
Compare
Last issues remaining:
|
CHANGELOG.md
Outdated
you ever need to. | ||
|
||
We've also tweaked the event system a little. All built-in event names are now | ||
available as constants under `choo.events`. And we've introduced three new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
three or two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good point - it's two brand new ones, and one that was introduced a
couple of weeks ago and folks might not be aware of. Will fix! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
upgrade to new nanobus remove nanohistory add nanotiming remove nanomount move newTree to next tick upgrade timing API add more node warnings to .start/.mount add morph timing pass app instance to .use() self-clearing async-timing clean up timings better mount error fix mount bug de-prototype helper functions update to latest nanotiming upgrade to nanotiming 5 update nanotiming add toString asserts more assertions add event based tracing expose createlocation assert return types from render to always be the same add navigate event expose route on state expose events update uglify use scroll-to-anchor update nanobus document events update docs more docs changelog v6 upgrade nanomorph fixup! neatify morph assertions update bel dep add popstate docs to changelog
📦 v6.0.0-0 (release candidate) Please share any feedback here #519. Thanks! 🎉 |
in-progress target branch we can use for breaking behavior. The prototype branch is basically a full rewrite; this allows us to put out some betas and iterate on the minor changes we want for the next version.
Basically I'm thinking we keep the API stable, but yeah there's a few nits that are technically breaking. So we should iron those out in a semver major. Yay for boring changes ✨
related issues
bel
yo-yoify
add whitespace collapse for bel 5 parity shama/yo-yoify#49pelo
Clean up whitespace shuhei/pelo#7yo-yoify
bel
to newpelo