(#2468) Remove deprecated Chocolatey commands #2550
Conversation
|
Should there be an upgrade path that removed the |
|
@corbob also not sure what you mean here, can you elaborate? |
|
So if I take the nupkg to a fresh system and install it, |
There was a problem hiding this comment.
Aside from the previous comment about possibly removing cver.exe on upgrade, it all looks good to me. My testing shows it all works as expected both from an upgrade and from a fresh install perspective.
The removal can be discussion and a separate PR if we decide that's something for us to do.
Just to make sure that are on the same page, I am reading this as:
If so, then yes, we need to add some steps to the chocolateyInstall.ps1 file to ensure that the To illustrate what happens... With version 0.12.1 of Chocolatey installed, attempting to run
When attempting to run it with the code from this PR, you get the following:
This is "bad" since the cver shim is still there, which is happening to run When we remove the cver shim, we then see the following:
Which is what we actually want to see. I will attempt to update this PR at some point to include the work to ensure that the cver shim is removed (unless someone beats me to this). |
|
I am converting this to a draft PR until the removal of the shim is completed. |
gep13
changed the title
There was a problem hiding this comment.
This overall looks good to me.
The only thing remaining is to remove the shim during upgrade.
The code for this is included in the PR #2551 and the only change needed for this PR would be to add the cver executable to the list of shims to remove.
This command is no longer required, and has been replaced by either the choco list or the choco upgrade --noop commands depending on whether you are attempting to get locally installed items, or checking to see what upgrades are available. In addition, the cver shim has also been removed.
This command has been replaced by the choco upgrade command. At some point, the choco update command will be re-instated, with the purpose of updating the local package index of packages.
|
@gep13 Thanks for getting this added 👍 |
The following Chocolatey commands have been marked as deprecated for a while now, and with the upcoming release of 1.0.0, it is time to remove them:
The functionality of these commands is now provided elsewhere, and these commands can be removed.
In addition, the shim for
cverhas also been removed.Fixes #2468
https://app.clickup.com/t/20540031/ENGTASKS-723