(#89) Remove cpack shim for choco pack

[gep13]

There are known incompatibilities with this shim when other applications
are installed on the machine, for example cmake. Since we are moving
towards usage of a ubiquitous choco command, removing this shim makes
a lot of sense.

Fixes #89

[corbob]

Should there be an upgrade path that removed the cpack.exe shim?

[gep13]

@corbob I am not sure if I follow what you mean here. Can you elaborate?

[corbob]

So if I take the nupkg to a fresh system and install it, cpack.exe is not there. But if I already have Chocolatey on the box and do choco upgrade chocolatey cpack.exe is still on the path.

[TheCakeIsNaOH]

cpack.exe is still on the path.

What if a user replaced the cpack.exe that points to choco pack and instead has a shim that points to the cmake cpack?

Or what if a user manually created a cpack.exe that points to choco pack, since they wanted the functionality back? If there was code that removed the shim, then that manually created shim might be removed on upgrade.

Although removing the shim still might be the best course of action, there are lots of edge cases.

[gep13]

@TheCakeIsNaOH said...
Although removing the shim still might be the best course of action, there are lots of edge cases.

Agreed. There is a long standing "rule" that Chocolatey package installations shouldn't directly we adding anything into the Chocolatey bin folder, and the same rule should apply to folks directly adding files in there. Obviously we can't stop someone doing this if they really want to, but they can't expect that Chocolatey (in future versions) won't do something that results in something that they have done manually stops working.

We have discussed this within the team, and the plan going forward would be to check whether the cpack shim exists, if it does, if it is signed with either the Chocolatey Software or Real Dimensions Authenticode signature, we will delete it, as we know that we placed it there, otherwise, we will leave it alone.

[gep13]

Converting to to draft until an addition to the chocolateyInstall.ps1 file is made to affect the removal of the cpack shim from the bin folder on upgrade to 1.0.0.

[AdmiringWorm]

LGTM.

As I added the changes in the PowerShell file I'll need a second pair of eyes to ensure it both works as expected and looks fine.

[corbob]

Just the one comment from my perspective.

[gep13]

Small change...

[gep13]

@AdmiringWorm thanks for getting this over the line!

[AdmiringWorm]

@gep13 it was a pretty big line, but finally got there eventually 😆