Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-1231) Use DirectoryInfo to evaluate CacheLocation #1233

Merged
merged 1 commit into from
May 1, 2017

Conversation

mwrock
Copy link
Member

@mwrock mwrock commented Apr 4, 2017

The former fix (GH-1210) fails when the CacheLocation ends with a slash. This uses a DirectoryInfo instance to examine the last directory in the path in a more robust manner

Closes #1231

The former fix (chocolateyGH-1210) fails when the CacheLocation ends with a slash. This uses a DirectoryInfo instance to examine the last directory in the path in a more robust manner
@mwrock mwrock force-pushed the fix_temp_for_reals branch from a3e2a88 to 75fb33b Compare April 4, 2017 07:32
@mwrock
Copy link
Member Author

mwrock commented Apr 4, 2017

Dropping the use of is_equal_to for the vanilla String.Equals to get integration tests green

Copy link
Member

@ferventcoder ferventcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix temp for reals. hashtag fixed

@ferventcoder ferventcoder self-assigned this Apr 5, 2017
@flcdrg
Copy link
Member

flcdrg commented Apr 6, 2017

Looking forward to getting this in so we can get a new boxstarter build :)

@batzen
Copy link

batzen commented Apr 27, 2017

@ferventcoder Any chance to get this merged? I am unable to provision machines because of this...

@ferventcoder
Copy link
Member

Hi @batzen - yes. This is being worked on currently.

@ferventcoder ferventcoder merged commit d5eebf4 into chocolatey:stable May 1, 2017
@amaau
Copy link

amaau commented Jul 27, 2017

still a problem in 0.10.7

@ferventcoder
Copy link
Member

ferventcoder commented Jul 27, 2017

@amaau Actually it's not, but @mwrock had to downgrade the chocolatey.lib in Boxstarter back to 0.10.5 due to another issue.

@amaau
Copy link

amaau commented Jul 27, 2017

ahaa, apologies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants