-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(GH-1231) Use DirectoryInfo to evaluate CacheLocation #1233
Conversation
The former fix (chocolateyGH-1210) fails when the CacheLocation ends with a slash. This uses a DirectoryInfo instance to examine the last directory in the path in a more robust manner
a3e2a88
to
75fb33b
Compare
Dropping the use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix temp for reals. hashtag fixed
Looking forward to getting this in so we can get a new boxstarter build :) |
@ferventcoder Any chance to get this merged? I am unable to provision machines because of this... |
Hi @batzen - yes. This is being worked on currently. |
still a problem in 0.10.7 |
ahaa, apologies |
The former fix (GH-1210) fails when the CacheLocation ends with a slash. This uses a DirectoryInfo instance to examine the last directory in the path in a more robust manner
Closes #1231