(GH-1231) Use DirectoryInfo to evaluate CacheLocation #1232
Conversation
When the wait time is 0, do not set a timeout on the execute task.Wait.
|
I just tested the appveyor drop with boxstarter and this looks to be working. |
|
fixes #1231 |
| // the API. | ||
| if(!config.CacheLocation.EndsWith("chocolatey")) { | ||
| // the API. | ||
| if(new DirectoryInfo(config.CacheLocation).Name.ToLower() != "chocolatey") { |
There was a problem hiding this comment.
Use fileSystem.get_directory_info() and use either .to_lower() or Name.is_equal_to(). The latter is preferred.
mwrock
force-pushed
the
fix_temp_for_reals
branch
2 times, most recently
from
0d8f34c to
9835125
Compare
|
hmm this is dying with |
My guess?
|
|
well |
|
actually its |
|
So it is. So it is. |
|
ok. I just ran BTW: the build.bat breaks on nuget.exe in the choco repo. If I swap in the latest nuget.exe the nuget installs work but then the build fails in ilmerge.exe. I think the nuget problems are due to API incompatibilities with older nuget clients (just an educated guess). Anyways I found that vanilla msbuild ended up being the easiest way for me to locally sanity check the build. |
|
Looking again at the appveyor log I actually think this is a test setup issue and not related directly to the config builder itself. Perhaps somthing needs to be imported or added to a container. |
|
Don't get too hung up on the appveyor issues. Also, as a committer, you may think about using stable and not master. |
PowerShell is not very good at telling the difference between ANSI and UTF8 w/out BOM, so PowerShell scripts are not able to be verified by what is built into PowerShell authenticode verification if they use UTF8 no BOM with unicode characters. This follows up on chocolatey#1209 where it was discovered that the authenticode verification would not work with LF line endings. That was resolved and later a unicode character (copyright) was introduced, which broke the functionality again. Convert all scripts to UTF8 w/BOM.
Ensure NOTICE lists Chocolatey Software as the new copyright holder.
The Chocolatey Package was getting the license copied, but the library was not. Ensure that it receives the licensing files as well. Add the notice and credits as outputs to that.
Ensure NOTICE looks like what choco bakes in
Choco already unpacks the License file. It is the same text as the NOTICE file, so ensure that is is used and not overwritten.
Ensure credits is set properly with licenses.
The former fix (chocolateyGH-1210) fails when the CacheLocation ends with a slash. This uses a DirectoryInfo instance to examine the last directory in the path in a more robust manner
mwrock
force-pushed
the
fix_temp_for_reals
branch
from
9835125 to
fb396c3
Compare
|
closing in favor of #1233 targeting stable |
The former fix (GH-1210) fails when the CacheLocation ends with a slash. This uses a DirectoryInfo instance to examine the last directory in the path in a more robust manner