Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect output regarding package files when package can't be found to be downloaded #1962

Closed
Xalaxis opened this issue Dec 1, 2019 · 1 comment · Fixed by #1979
Closed

Incorrect output regarding package files when package can't be found to be downloaded #1962

Xalaxis opened this issue Dec 1, 2019 · 1 comment · Fixed by #1979
Labels
5 - Released Bug
Milestone
0.11.0

Comments

@Xalaxis
Copy link

Xalaxis commented Dec 1, 2019

Hi all, it looks like the Chocolatey servers are (partially) down right now. That's not the point of this enhancement request though. Currently if the servers are (partially) down, you get the message shown below:
image

It doesn't really seem to make sense to report that an error has occurred and a package upgrade was not successful, before then saying the upgrade is complete and trying the same thing again. Perhaps the whole process could fall over if the first network access fails?
@ferventcoder
Copy link
Member

This is definitely a weird place to report that the package files upgrade is completed (not the software installation or any of the scripts running) - note this is not a message saying the upgrade is complete - "package files upgraded" is not "upgrade is complete". Still we shouldn't have that message show if there is an error.

@ferventcoder ferventcoder changed the title "Error occurred during installation" When there is an error getting a package, do not report the package files upgrade aspect has completed Jan 2, 2020
@ferventcoder ferventcoder added this to the 0.10.16 milestone Jan 2, 2020
cowmanjoe added a commit to cowmanjoe/choco that referenced this issue Jan 5, 2020
@cowmanjoe
(chocolateyGH-1962) Use a different message for error result in handl…
f7aff3f 
…e_package_result.

Currently, the method logs that the command was "completed" even if it failed. A log that says the step failed would make more sense to the user in this case.
@cowmanjoe cowmanjoe mentioned this issue Jan 5, 2020
Merged
gep13 pushed a commit to cowmanjoe/choco that referenced this issue Apr 19, 2021
@cowmanjoe @gep13
(chocolatey#1962) Use different message on error
623f6b3 
Currently, the method logs that the command was "completed" even if it
failed. A log that says the step failed would make more sense to the
user in this case.
gep13 pushed a commit to cowmanjoe/choco that referenced this issue Apr 19, 2021
@cowmanjoe @gep13
(chocolatey#1962) Use different message on error
8e38976 
Currently, the method logs that the command was "completed" even if it
failed. A log that says the step failed would make more sense to the
user in this case.
gep13 added a commit that referenced this issue Apr 19, 2021
@gep13
Merge pull request #1979 from cowmanjoe/GH-1962-better-error-log
b1d8b92 
(#1962) Use different message on error
@gep13 gep13 closed this as completed Apr 19, 2021
steviecoaster added a commit to steviecoaster/choco that referenced this issue May 11, 2021
@steviecoaster
Merge branch 'GH2112' of https://github.com/steviecoaster/choco into …
61102d6 
…GH2112

* 'GH2112' of https://github.com/steviecoaster/choco:
  (chocolatey#2112) Add msp support to Install helper
  (maint) Switch to using a Regex match
  (maint) Change formatting
  (maint) Remove use of PowerShell aliases
  (maint) Replace " with '
  (chocolatey#2044) Fix for changing $env:Temp
  (chocolatey#2259) Switched to versioned NuGet.Core
  (chocolatey#2111) Deep copy config
  (chocolatey#2244) Add Mac build into main workflow
  (chocolatey#2238) Mono build don't hardcode xbuild path
  (maint) Fix artifact paths on AppVeyor
  (chocolatey#2244) Fix syntax for running on Windows
  (chocolatey#2244) Initial workflow for Windows and Ubuntu
  (doc) Remove Mono instructions for other distributions
  (doc) Add Ubuntu 20.04 mono install instructions
  (chocolatey#2227) Bump Mono version in Dockerfile and README
  (chocolatey#2236) Mono test work with merged usr systems
  (chocolatey#2190) Clarify help for SpecificFolder parameter
  (chocolatey#1962) Use different message on error
  (chocolatey#1861) Improves terminology in help documentation
  (chocolatey#1998) Add authorization header to Get-WebFile
  (maint) Repalce RawGit with raw.githack.com CDN
  (chocolatey#1899) Remove unused variables
  (chocolateyGH-1060) Add BeforeInstall parameter to Install-ChocolateyPackage.ps1
  (maint) Improve log message
  (chocolateyGH-2092) Take all registry keys into account
  (chocolateyGH-1364) Template create .nuspec encoded without BOM
  (chocolatey#1866) Limit pending package removal to top level
  (chocolateyGH-2203) Get-ChocolateyUnzip add unzipLocation alias
  (chocolateyGH-1889) Fix: Removal of ApiKey broken
  (chocolatey#2114) Remove unused variable
  (chocolateyGH-2048) update deprecation note to outdated
  (maint) Spelling and grammar fixes
  (maint) Replace tabs with spaces
  (chocolatey#2078) Skip importing Chocolatey GUI Extension
  (chocolatey#2227) Use latest Mono and Ubuntu on Travis
  (chocolatey#2205) Remove mention of private repository
  (chocolatey#2205) Update remaining URLs to new location
  (maint) Remove unnecessary whitespace
  (chocolatey#2231) Change default repository URL
  (maint) Remove unnecessary whitespace
  (chocolatey#2205) Update all chocolatey.org/docs URLs
  (maint) Remove unnecessary whitespace
  (chocolatey#2205) Update automatic-packages docs links
  (doc) Update to prefer # rather than GH-
  (maint) Fix replacement
  (maint) Revert change to earlier commit
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (doc) Update script to Statiq format
  (maint) Add missing backtick in example
  (maint) Added explicit link to new function name
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Fix spelling mistake
  (maint) Remove generated docs files
  (maint) Add docs/generated folder to ignore list
  (chocolateyGH-2105) Update link to Chocolatey workshop
@gep13 gep13 changed the title When there is an error getting a package, do not report the package files upgrade aspect has completed Incorrect output regarding package files when package can't be found to be downloaded May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released Bug
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

(#1962) Use different message on error cowmanjoe/choco
3 participants
@ferventcoder @gep13 @Xalaxis