Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(1password) Fixed silent installation #1516

Merged
merged 3 commits into from
Aug 4, 2020

Conversation

mkevenaar
Copy link
Member

@mkevenaar mkevenaar commented Aug 1, 2020

Description

The new installer requires --silent to be used for the installation of 1Password 7
Also .NET framework 4.7.2+ is now required for 1Password 7.

Motivation and Context

Fixes #1186

How Has this Been Tested?

Tested on chocolatey-test-environment

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

@mkevenaar mkevenaar requested a review from AdmiringWorm August 1, 2020 14:43
@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

automatic/1password/update.ps1 Outdated Show resolved Hide resolved
The new installer requires --silent to be used for the
installation of 1Password 7
@AppVeyorBot
Copy link

❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look.

@mkevenaar
Copy link
Member Author

@AdmiringWorm build failed on AppVeyor, however runs fine (after reboot) on the Chocolatey Test Environment.

@RedBaron2
Copy link
Contributor

@mkevenaar
It works fine after reboot due to dotnet 4.7.2 requiring a reboot to complete installation.
Just FYI it still points to beforeupdate

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@AdmiringWorm
Copy link
Member

@mkevenaar it turns out that the failure on appveyor was not caused by any of your changes in this PR.
I did however fix those issues, and submitted those changes to this PR.

Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AdmiringWorm AdmiringWorm merged commit 9446074 into chocolatey-community:master Aug 4, 2020
@AdmiringWorm
Copy link
Member

@mkevenaar your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(1password) Installation failed due to change in installer
4 participants