-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(1password) Fixed silent installation #1516
(1password) Fixed silent installation #1516
Conversation
❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look. |
The new installer requires --silent to be used for the installation of 1Password 7
ba216ad
to
195569c
Compare
❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look. |
@AdmiringWorm build failed on AppVeyor, however runs fine (after reboot) on the Chocolatey Test Environment. |
@mkevenaar |
✅ Package verification completed without issues. PR is now pending human review |
@mkevenaar it turns out that the failure on appveyor was not caused by any of your changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mkevenaar your changes have been merged, thanks for your contribution 👍 |
Description
The new installer requires --silent to be used for the installation of 1Password 7
Also .NET framework 4.7.2+ is now required for 1Password 7.
Motivation and Context
Fixes #1186
How Has this Been Tested?
Tested on chocolatey-test-environment
Screenshot (if appropriate, usually isn't needed):
Types of changes
Checklist: