Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(1password) install appears to succeed, but program is not functional #1618

Closed
jacktose opened this issue Feb 23, 2021 · 14 comments
Closed

(1password) install appears to succeed, but program is not functional #1618

jacktose opened this issue Feb 23, 2021 · 14 comments

Comments

@jacktose
Copy link

Expected Behavior

choco install 1password should end with a functional install of 1Password.

Current Behavior

choco install 1password appears to complete successfully (with a fair bit of stderr output).
1Password does not appear in Start menu, desktop, Apps & features, or Programs & features.
1Password files are present in %LOCALAPPDATA%\1Password\.

Possible Solution

In #1186, an installer change broke choco installation and was fixed in #1516. I don't think this is exactly the same, because -f --not-silent is not an effective workaround.

Steps to Reproduce (for bugs)

choco install 1password
or
choco install --not-silent 1password and click Yes at the prompt

Context

I'm a new 1Password user and just want to install and use the program.

Your Environment

@alie2n
Copy link

alie2n commented May 10, 2021

I just came access the same issue. I can confirm that this problem exists on a brand new, fresh installed, Windows 10 20H1.
It seems, that the last step for the installation %LOCALAPPDATA%\1Password\1Password.exe setup should now be %LOCALAPPDATA%\1Password\1Password.exe --silent

@RedBaron2
Copy link
Contributor

@alie2n
Would you be willing to submit a PR with the changes needed?

@alie2n
Copy link

alie2n commented May 17, 2021

I'd really like to submit a PR, but I don't understand the logic how the executed command gets assembled. From what I gather from the install.ps1 and the update.ps1 the command should be correct. But for some reason it is not.

@michaelmhoffman
Copy link

I am having the same issue. Running %LOCALAPPDATA%\1Password\1Password.exe --silent runs 1Password, but it didn't seem to install it in the start menu, but %LOCALAPPDATA%\1Password\1Password.exe setup did.

@michaelmhoffman
Copy link

The current installer logic kills the installer after it finds "Installation completed successfully" in the log. Is it possible that this is no longer really enough to complete installation?

@AdmiringWorm
Copy link
Member

It is very possible that it is no longer needed, or the installation completed is prematurely added to the log.

I am not a user of 1password myself, so need to leave this up to someone else to investigate.

@michaelmumenthaler
Copy link
Contributor

The issue still persists, after some testing i found that an additional step is needed to finish the installation. I added this step to the code and created a PR (#1733). With that change 1Password appears in the startmenu, appwiz etc.

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue will be closed in 14 days if it continues to be inactive.

@jacktose
Copy link
Author

#1733 is still open to fix this. Looks like it just needs some attention.

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue will be closed in 14 days if it continues to be inactive.

@GarethBlain
Copy link

This is still an issue. It seems that the PR to fix it has been closed due to nobody understanding enough about the strange merged versions of 1password and the now old 1password4 system. Can anyone help to get this closed off?

@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue will be closed in 14 days if it continues to be inactive.

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

Dear contributor,

As this issue seems to have been inactive for quite some time now, I've automatically closed it.
If you feel this is a valid issue, please feel free to re-open the issue if/when a pull request
has been added.
Thank you for your contribution.

@compuguy
Copy link

This is still an issue as of Nov 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants