Unified network configuration generation

.github/scripts/ensure_set_euox_pipefail.sh

@@ -6,18 +6,21 @@ set -euo pipefail
 
 INVALID_FILES_FOUND=0
 
-for BASH_SCRIPT in $(find . -type f -name "*.sh")
+while IFS= read -r -d '' BASH_SCRIPT
 do
+    echo "checking ${BASH_SCRIPT}"
     if ( ! grep -q "set -euo pipefail" "${BASH_SCRIPT}" ) && ( ! grep -q "set -euox pipefail" "${BASH_SCRIPT}" )
     then
         echo "${BASH_SCRIPT}"
         INVALID_FILES_FOUND=1
     fi
-done
+done < <(find . -type f -name "*.sh" -print0) # See https://github.com/koalaman/shellcheck/wiki/SC2044
 
 if [[ INVALID_FILES_FOUND -eq 1 ]]
 then
     echo ""
     echo "The bash scripts above must include either 'set -euo pipefail' or 'set -euox pipefail."
     exit 1
+else
+    echo "euox-pipefaile check finished successfully"
 fi

.github/workflows/lint.yml

@@ -55,6 +55,7 @@ jobs:
         VALIDATE_XML: true
         VALIDATE_YAML: true
         VALIDATE_OPENAPI: true
+        VALIDATE_BASH: true
 
         VALIDATE_ALL_CODEBASE: true
         LOG_LEVEL: WARN

.github/workflows/release.yml

@@ -6,37 +6,12 @@ on:
       - "v*"
 
 jobs:
-  setup-workflow:
-    name: "Setup workflow"
-    runs-on: ubuntu-latest
-    outputs:
-      GITHUB_REPOSITORY_NAME: ${{ steps.cache.outputs.GITHUB_REPOSITORY_NAME }}
-      GITHUB_ORG_NAME: ${{ steps.cache.outputs.GITHUB_ORG_NAME }}
-      TAG: ${{ steps.cache.outputs.TAG }}
-      VERSION: ${{ steps.cache.outputs.VERSION }}
-    steps:
-      - name: Git checkout
-        uses: actions/checkout@v2
-
-      - name: Set outputs
-        id: cache
-        run: |
-          # Exposes org_name in lower case. Required by Docker.
-          echo "::set-output name=GITHUB_ORG_NAME::$(echo ${GITHUB_REPOSITORY_OWNER,,})"
-
-          # Exposes org_name/repository_name in lower case. Required by Docker.
-          echo "::set-output name=GITHUB_REPOSITORY_NAME::$(echo ${GITHUB_REPOSITORY,,})"
-
-          # Version is tag without `v` prefix. Required by Debian package.
-          TAG=${GITHUB_REF/refs\/tags\//}
-          echo "::set-output name=TAG::$TAG"
-
-          VERSION="${TAG:1}" # Remove first character
-          echo "::set-output name=VERSION::$VERSION"
 
   build-binary:
     name: Build binary
     runs-on: ubuntu-20.04
+    outputs:
+      VERSION: ${{ steps.set-version.outputs.VERSION }}
     steps:
       - name: Set up Go 1.17
         uses: actions/setup-go@v2
@@ -81,59 +56,86 @@ jobs:
           name: cheqd-noded
           path: build/cheqd-noded
 
-  build-deb-package:
-    name: Build Debian package
+      - name: Set version
+        id: set-version
+        run: |
+          VERSION=$(build/cheqd-noded version 2>&1)
+          echo "::set-output name=VERSION::$VERSION"
+
+  build-tar-package:
+    name: Build tar package
     runs-on: ubuntu-20.04
-    needs: [ build-binary, setup-workflow ]
+    needs: build-binary
     env:
-      PACKAGE_NAME: "cheqd-node"
-      VERSION: ${{ needs.setup-workflow.outputs.VERSION }}
+      VERSION: ${{ needs.build-binary.outputs.VERSION }}
     steps:
       - uses: actions/checkout@v2
 
       - name: Load binary artifact
         uses: actions/download-artifact@v2
         with:
           name: cheqd-noded
-          path: /home/runner/go/bin
 
       - name: Restore binary permissions
-        run: sudo chmod +x /home/runner/go/bin/cheqd-noded
+        run: sudo chmod +x cheqd-noded
 
-      - name: Make intermediate archive
+      - name: Build tar
         working-directory: ./build-tools
         run: |
-          ./build-tar.sh ${{ env.PACKAGE_NAME }} ${{ env.VERSION }}
+          ./build-tar.sh "../cheqd-noded"
+
+      - name: Store tar package artifact
+        uses: actions/upload-artifact@v2
+        with:
+          name: cheqd-node_${{ env.VERSION }}.tar.gz
+          path: build-tools/output/cheqd-node_${{ env.VERSION }}.tar.gz
+
+  build-deb-package:
+    name: Build Debian package
+    runs-on: ubuntu-20.04
+    needs: [ build-binary ]
+    env:
+      VERSION: ${{ needs.build-binary.outputs.VERSION }}
+    steps:
+      - uses: actions/checkout@v2
+
+      - name: Load binary artifact
+        uses: actions/download-artifact@v2
+        with:
+          name: cheqd-noded
+
+      - name: Restore binary permissions
+        run: sudo chmod +x cheqd-noded
 
       - name: Install fpm
         run: |
           sudo apt-get install ruby ruby-dev rubygems build-essential
           sudo gem install --no-document fpm
 
-      - name: Build Debian package # Depends on tar archive
+      - name: Build deb
         working-directory: ./build-tools
         run: |
-          ./build-deb.sh ${{ env.PACKAGE_NAME }} ${{ env.VERSION }}
+          ./build-deb.sh "../cheqd-noded"
 
       - name: Store Debian package artifact
         uses: actions/upload-artifact@v2
         with:
-          name: ${{ env.PACKAGE_NAME }}_${{ env.VERSION }}_amd64.deb
-          path: build-tools/output/${{ env.PACKAGE_NAME }}_${{ env.VERSION }}_amd64.deb
+          name: cheqd-node_${{ env.VERSION }}_amd64.deb
+          path: build-tools/output/cheqd-node_${{ env.VERSION }}_amd64.deb
 
-  build-node-image:
-    name: Build cheqd-node Docker image
+  build-node-images:
+    name: Build cheqd-node and cheqd-cli images
     runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v2
         with:
-          fetch-depth: 0 # FIXME: Starport requires full repository
+          fetch-depth: 0 # Required to fetch version
 
       - name: Build cheqd-cli with 'cheqd-noded' as entrypoint
-        run: docker build --target base -t cheqd-cli -f docker/Dockerfile --build-arg UID=$(id -u) --build-arg GID=$(id -g) .
+        run: docker build --target base -t cheqd-cli -f docker/Dockerfile .
 
       - name: Build cheqd-node with 'node-start' as entrypoint
-        run: docker build --target node -t cheqd-node -f docker/Dockerfile --build-arg UID=$(id -u) --build-arg GID=$(id -g) .
+        run: docker build --target node -t cheqd-node -f docker/Dockerfile .
 
       - name: Save cheqd-cli
         run: docker save -o cheqd-cli-image.tar cheqd-cli
@@ -156,7 +158,7 @@ jobs:
   build-testnet-image:
     name: Build cheqd-testnet image
     runs-on: ubuntu-20.04
-    needs: build-node-image
+    needs: build-node-images
     steps:
       - name: Check out
         uses: actions/checkout@v2
@@ -184,15 +186,10 @@ jobs:
   publish:
     name: "Publish images and release"
     # Reference to workflow-setup job is required to access its various outputs.
-    needs: [ setup-workflow, build-node-image, build-testnet-image, build-deb-package ]
+    needs: [ build-binary, build-node-images, build-testnet-image, build-deb-package, build-tar-package ]
     runs-on: ubuntu-latest
     env:
-      GITHUB_REPOSITORY_NAME: ${{ needs.setup-workflow.outputs.GITHUB_REPOSITORY_NAME }}
-      GITHUB_ORG_NAME: ${{ needs.setup-workflow.outputs.GITHUB_ORG_NAME }}
-      TAG: ${{ needs.setup-workflow.outputs.TAG }}
-      VERSION: ${{ needs.setup-workflow.outputs.VERSION }}
-      PACKAGE_NAME: "cheqd-node"
-      TESTNET_IMAGE_NAME: "cheqd-testnet"
+      VERSION: ${{ needs.build-binary.outputs.VERSION }}
     steps:
       - name: Git checkout
         uses: actions/checkout@v2
@@ -227,10 +224,10 @@ jobs:
 
       - name: Push cheqd-node image
         run: |
-          docker tag cheqd-node ghcr.io/${{ env.GITHUB_REPOSITORY_NAME }}:${{ env.VERSION }}
-          docker tag cheqd-node ghcr.io/${{ env.GITHUB_REPOSITORY_NAME }}:latest
-          docker push ghcr.io/${{ env.GITHUB_REPOSITORY_NAME }}:${{ env.VERSION }}
-          docker push ghcr.io/${{ env.GITHUB_REPOSITORY_NAME }}:latest
+          docker tag cheqd-node ghcr.io/${{ github.repository }}:${{ env.VERSION }}
+          docker tag cheqd-node ghcr.io/${{ github.repository }}:latest
+          docker push ghcr.io/${{ github.repository }}:${{ env.VERSION }}
+          docker push ghcr.io/${{ github.repository }}:latest
 
 
       - name: Push cheqd-cli image
@@ -242,32 +239,26 @@ jobs:
 
       - name: Push testnet image
         run: |
-          docker tag cheqd-testnet ghcr.io/${{ github.repository_owner }}/${{ env.TESTNET_IMAGE_NAME }}:${{ env.VERSION }}
-          docker tag cheqd-testnet ghcr.io/${{ github.repository_owner }}/${{ env.TESTNET_IMAGE_NAME }}:latest
-          docker push ghcr.io/${{ github.repository_owner }}/${{ env.TESTNET_IMAGE_NAME }}:${{ env.VERSION }}
-          docker push ghcr.io/${{ github.repository_owner }}/${{ env.TESTNET_IMAGE_NAME }}:latest
+          docker tag cheqd-testnet ghcr.io/${{ github.repository_owner }}/cheqd-testnet:${{ env.VERSION }}
+          docker tag cheqd-testnet ghcr.io/${{ github.repository_owner }}/cheqd-testnet:latest
+          docker push ghcr.io/${{ github.repository_owner }}/cheqd-testnet:${{ env.VERSION }}
+          docker push ghcr.io/${{ github.repository_owner }}/cheqd-testnet:latest
 
       - name: Download deb
         uses: actions/download-artifact@v2
         with:
-          name: ${{ env.PACKAGE_NAME }}_${{ env.VERSION }}_amd64.deb
+          name: cheqd-node_${{ env.VERSION }}_amd64.deb
 
-      - name: Load binary artifact
+      - name: Download tar
         uses: actions/download-artifact@v2
         with:
-          name: cheqd-noded
-
-      - name: Restore binary permissions
-        run: sudo chmod +x cheqd-noded
-
-      - name: Make tar archive
-        run: tar -zcvf ${{ env.PACKAGE_NAME }}_${{ env.VERSION }}.tar.gz cheqd-noded
+          name: cheqd-node_${{ env.VERSION }}.tar.gz
 
       - uses: "marvinpinto/action-automatic-releases@latest"
         with:
           repo_token: "${{ secrets.GITHUB_TOKEN }}"
-          automatic_release_tag: "${{ env.TAG }}"
+          automatic_release_tag: "${{ env.GITHUB_REF_NAME }}"
           prerelease: true
           files: |
-            ${{ env.PACKAGE_NAME }}_${{ env.VERSION }}_amd64.deb
-            ${{ env.PACKAGE_NAME }}_${{ env.VERSION }}.tar.gz
+            cheqd-node_${{ env.VERSION }}_amd64.deb
+            cheqd-node_${{ env.VERSION }}.tar.gz