Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified network configuration generation #267

Merged
merged 97 commits into from
Feb 11, 2022
Merged

Conversation

askolesov
Copy link
Contributor

@askolesov askolesov commented Jan 12, 2022

Waits for #250. TODO: Redirect to main after the PR is merged.

@askolesov
Copy link
Contributor Author

lampkin-diet
lampkin-diet previously approved these changes Jan 25, 2022
Base automatically changed from new-docker-compose to main January 26, 2022 16:20
* Fix ensure_set_euox script

* Optimize pipelines

* Fix job dependencies

* Debugging archive creation

* Fix paths

* Fix version fetching

* Fix docker build

* Fix fpm install

* Fix env vars

* Fix artifact name

* Fixing bash issues

* Fix remaining linter issues

* Enable bash linter in wrkflows

* Fix proto build

* Fix proto gen

* Fix protogen.sh

* Fix cli tests

* Fixx protogen.sh
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment to discuss/resolve before closing

.github/workflows/release.yml Show resolved Hide resolved
Copy link
Contributor

@ankurdotb ankurdotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved @askolesov BUT maybe we can set some time tomorrow to chat through the localnet. Basically, I don't think we need docker-localnet folder any more. We can do everything using docker-compose-localnet. Would you agree?

I'm happy for this one to be merged in, and we can use the other PR - where we rename the image to localnet - to account for those changes.

@askolesov askolesov merged commit a18497a into main Feb 11, 2022
@askolesov askolesov deleted the unified-net-config-generation branch February 11, 2022 09:22
lampkin-diet pushed a commit that referenced this pull request Feb 28, 2022
* Refactor: Docker Compose Easy Setup

Signed-off-by: jay-dee7 <[email protected]>

* Changed action to reflect the updates

* Add: long-syntax for ports in docker-compose config

Signed-off-by: jay-dee7 <[email protected]>

* File structure and workflows

* Switched permissions

* Copy as root then own it

* Added permissions

* Created localnet setup extracted from workflow

* Removed volume from Dockerfile

* Switched directory to match changes

* Fixed to match new image settings

* External laddr availability

* Switched test port to avoid clashes

* Bypass defaults

* Removed excess

* Removed moniker name in container env vars

Signed-off-by: jay-dee7 <[email protected]>

* Fixed supervisor config to match dirs

* Removed unwanted quotes

* Switched to reflect main

* Single Dockerfile for mainnet & testnet

* Adjusted to old dir

* Removed excess

* Upgraded testnet version beforehand

* Added whole home dir volume

* Multiple driver options & fixes

* Testnet ref typo fix

* Consistent across mainnet & testnet

* Moved environment variables to host

* Move single image localnet to tests

* Fix naming of build tools

* Fx liinks in workflows

* Move docker localnet to tests

* Fix documentation

* Fix case

* Fix broken links

* Allow 0, 403 status codes for link checker

* Fix broken links

* Fix file names

* Fx links, dockerfile

* Fix test pipeline

* Fix test pipeline

* Fix test

* Revert volume names

* Fix corner case where host ip is invalid at first launch

* Optimize docker file

* Improve gen-network-config

* Update git ignore

* Update cheqd-localnet image to run several nodes inside again

* Corrected spelling in filename

* Make docker-compose localnet to use unified gen-net-conf base script

* Fix script name in the lint pipeline

* Fix permissions in the test pipeline

* Replace waiter script with the new one

* Typo fixes in GitHub Actions release workflow

* Cosmetic switch to put exposed ports in same order as in config files

* Swapping parameter order around in node-runner.sh

* Added explanatory comments to Docker Compose file

* Added extended descriptions for inside-container configuration file for mainnet

* Update Dockerfile

* Modified configuration for volumes in Docker Compose file

* Extended descriptions in host environment variables

* Update .Dockerignore

* Update release.yml

* Update .gitignore

* Fix paths

* More path fixes

* Fix paths

* Fix typos

* Fix failing tests

* Changed node-runner script to copy genesis and seed config data from Docker Compose config locations

* Optimise Dockerfile by removing unnecessary requirements

- Removed unused apt-get install packages in Docker build stages
- Added comments for readability

* Fixed errors due to incorrect commenting style in Compose environment file

* Fixed incorrect variable names in Docker Compose file

* Enable bash linter (#271)

* Fix ensure_set_euox script

* Optimize pipelines

* Fix job dependencies

* Debugging archive creation

* Fix paths

* Fix version fetching

* Fix docker build

* Fix fpm install

* Fix env vars

* Fix artifact name

* Fixing bash issues

* Fix remaining linter issues

* Enable bash linter in wrkflows

* Fix proto build

* Fix proto gen

* Fix protogen.sh

* Fix cli tests

* Fixx protogen.sh

* Fix step name

* Get rid of files included because of merge conflict

* Fix build-tar, build-deb scripts

* Various merge fixes

* Fix docker-compose-localnet merge conflicts

* Fix images build job names

* More merge fixes

* Fix base image

* Improve job names

* Fix test job

* Restore docker-compose required for the upgrade tests

* Fix docker-compose up

* Fix broken link

* Fix lint issues in common.sh

* Fix linter issues

* Fix typo

Co-authored-by: jay-dee7 <[email protected]>
Co-authored-by: Tasos <[email protected]>
Co-authored-by: Ankur Banerjee <[email protected]>
Signed-off-by: Andrew Nikitin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants