Logging methods (debug, info, warn, error, fatal) all return nil #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
changed the title
olleolleolle
force-pushed
the
feature/logger-methods-to-return-nil
branch
2 times, most recently
from
36b4707 to
a339b37
Compare
- Fixes chef#21 Signed-off-by: Olle Jonsson <[email protected]>
thommay
force-pushed
the
feature/logger-methods-to-return-nil
branch
from
a339b37 to
7be3c2e
Compare
thommay
approved these changes
Feb 28, 2018
|
@olleolleolle thanks so much for contributing this, and sorry it took so long to get merged. It'll ship with Chef Client 14 next month 🎉 |
|
\o/ Just sitting down reading the Chef versioning RFC to figure out how to make my puny V0 client stay on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
logger.debug "Hello"returnnil.Why would I need this?
Your existing code rescued and logged an exception using
warn. The return value of that invocation wasnil.Someone comes along to upgrade that
warnto use a configurable mixlib-log logger. The return value of that logged exception is now non-nil.