Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: logger.info to return nil #21

Closed
olleolleolle opened this issue Jan 25, 2017 · 1 comment
Closed

Feature Request: logger.info to return nil #21

olleolleolle opened this issue Jan 25, 2017 · 1 comment
Labels
Type: Enhancement Adds new functionality.

Comments

@olleolleolle
Copy link
Contributor

olleolleolle commented Jan 25, 2017

I would like logger's logging methods to return nil when they output messages.

Use-case: When logging a message at the end of an ensure clause one often means to "just print", and not return a list of outputters. Perhaps the logger.info used to be a puts. Now, its return value is non-nil and oy vey.

@olleolleolle
Copy link
Contributor Author

I guess it about the each that returns its receiver in places like https://github.com/chef/mixlib-log/blob/master/lib/mixlib/log.rb#L143

@tas50 tas50 added the Type: Enhancement Adds new functionality. label Apr 18, 2017
olleolleolle added a commit to olleolleolle/mixlib-log that referenced this issue Nov 21, 2017
olleolleolle added a commit to olleolleolle/mixlib-log that referenced this issue Nov 21, 2017
  - Fixes chef#21

Signed-off-by: Olle Jonsson <[email protected]>
olleolleolle added a commit to olleolleolle/mixlib-log that referenced this issue Nov 21, 2017
  - Fixes chef#21

Signed-off-by: Olle Jonsson <[email protected]>
thommay pushed a commit to olleolleolle/mixlib-log that referenced this issue Feb 28, 2018
  - Fixes chef#21

Signed-off-by: Olle Jonsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Adds new functionality.
Projects
None yet
Development

No branches or pull requests

2 participants