Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link resource: Remove checks for symoblic link support on Windows #9455

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Mar 6, 2020

Windows 2008+ has support for links. There's no reason to perform this check
every time on Windows. It's just wasting CPU cycles

Fixes #9416

Signed-off-by: Tim Smith [email protected]

2008+ have support for links. There's no reason to perform this check
every time on Windows. It's just wasting CPU cycles

Signed-off-by: Tim Smith <[email protected]>
@tas50 tas50 requested review from a team as code owners March 6, 2020 05:00
Copy link
Contributor

@phiggins phiggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nice cleanup! 👍

@tas50 tas50 merged commit c10d9ac into master Mar 6, 2020
@chef-expeditor chef-expeditor bot deleted the link_check branch March 6, 2020 20:11
@lock
Copy link

lock bot commented Mar 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

link resource: Remove checks for symbolic link support in Windows
2 participants