Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

link resource: Remove checks for symbolic link support in Windows #9416

Closed
tas50 opened this issue Feb 28, 2020 · 1 comment · Fixed by #9455
Closed

link resource: Remove checks for symbolic link support in Windows #9416

tas50 opened this issue Feb 28, 2020 · 1 comment · Fixed by #9455
Assignees
@tas50 @dheerajd-msys
Labels
Platform: Windows Type: Chore non-critical maintenance of a project.

Comments

@tas50
Copy link
Contributor

tas50 commented Feb 28, 2020

Description

Each time we try to create a link on Windows we check the system to see if symbolic links are supported. All the versions of windows we support can make symbolic links so we're wasting our time with this check.

Chef Version

master

Platform Version

Windows

Here's the portion of the link resource where we start the call:

chef/lib/chef/resource/link.rb

Line 81 in 8846dbc

def verify_links_supported!

There's also logic in the File class and various tests that should all be removed.
@tas50 tas50 added Platform: Windows Type: Chore non-critical maintenance of a project. Status: Sustaining Backlog labels Feb 28, 2020
@dheerajd-msys dheerajd-msys self-assigned this Mar 5, 2020
@tas50 tas50 mentioned this issue Mar 6, 2020
Merged
@tas50 tas50 closed this as completed Mar 6, 2020
@lock
Copy link

lock bot commented Mar 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tas50 tas50

@dheerajd-msys dheerajd-msys

Labels
Platform: Windows Type: Chore non-critical maintenance of a project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

link resource: Remove checks for symoblic link support on Windows chef/chef
2 participants
@tas50 @dheerajd-msys