Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: remove outdated docker file #441

Merged
merged 1 commit into from
Oct 22, 2022
Merged

config: remove outdated docker file #441

merged 1 commit into from
Oct 22, 2022

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Oct 22, 2022

#434 (review)

We do not need custom image

Remove dockerfile since it isn't needed and outdated.

@rnveach
Copy link
Member Author

rnveach commented Oct 22, 2022 •
edited
Loading

@romani
We were using 7.7-community-8c1737e before.

Lets remove the others at https://hub.docker.com/repository/docker/checkstyle/sonarqube-maven-git since they aren't needed and very outdated. We can keep 7.7 incase we need a fallback for now.

@sonarcloud
Copy link

sonarcloud bot commented Oct 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rnveach rnveach requested a review from romani October 22, 2022 20:19
@romani romani merged commit 30fdb36 into checkstyle:master Oct 22, 2022
@rnveach rnveach deleted the dockerfile branch October 22, 2022 20:43
@rnveach
Copy link
Member Author

rnveach commented Oct 22, 2022

@romani https://github.com/checkstyle/sonar-checkstyle/wiki/How-to-push-Dockerfile-to-docker-hub can be removed too?

@romani
Copy link
Member

romani commented Oct 23, 2022

Let me keep it, as it very useful manual how to upload all other docker containers.

@rnveach
Copy link
Member Author

rnveach commented Nov 1, 2022

@romani What about #441 (comment) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

Assignees

@romani romani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rnveach @romani