Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: fix build and plugin execution #434

Merged
merged 1 commit into from
Oct 22, 2022
Merged

infra: fix build and plugin execution #434

merged 1 commit into from
Oct 22, 2022

Conversation

rnveach
Copy link
Member

@rnveach rnveach commented Oct 18, 2022

Identified at #433 (comment)

@rnveach
Copy link
Member Author

rnveach commented Oct 18, 2022

https://app.circleci.com/pipelines/github/checkstyle/sonar-checkstyle/690/workflows/5c9a0e73-fd6f-4fa8-9a60-8384b0cbfdcf/jobs/664?invite=true#step-103-245
8 still failed.
https://github.com/SonarSource/docker-sonarqube/blob/8c80d5d9a234cba94b8472c2fee38e6229fed936/8/community/Dockerfile#L3
Docker file says it has 11, and has had it for a while.

@rnveach
Copy link
Member Author

rnveach commented Oct 18, 2022

Found some docker image maintenance at https://hub.docker.com/repository/docker/checkstyle/sonarqube-maven-git

@rnveach
Copy link
Member Author

rnveach commented Oct 18, 2022

https://app.circleci.com/pipelines/github/checkstyle/sonar-checkstyle/693/workflows/60b90dc0-263b-4a11-8013-459a9e470d60/jobs/667?invite=true#step-103-382
7.9-community-5302c42 is failing on compiling which is different.

No compiler is provided in this environment. Perhaps you are running on a JRE rather than a JDK?

@muhlba91
Copy link
Contributor

prerequisite: we will need to update the used image to use SQ 9+ as this is the current version necessary by the plugin. i did not find such image on dockerhub, though.

@rnveach rnveach force-pushed the circleci branch 4 times, most recently from affae91 to 40c8893 Compare October 22, 2022 15:52
@nrmancuso nrmancuso force-pushed the circleci branch 17 times, most recently from 1fc3e51 to 6bed351 Compare October 22, 2022 18:41
@nrmancuso
Copy link
Member

Build and execution of sonar takes less than 2 minutes, I do not see necessity of cache usage.

nrmancuso
nrmancuso reviewed Oct 22, 2022
View reviewed changes
.circleci/config.yml
Comment on lines +10 to +13
- persist_to_workspace:
root: /home/circleci
paths:
- project
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need composed images, since we can build jar and generate class files in previous step, and persist the project directory for sonar execution job.

nrmancuso
nrmancuso reviewed Oct 22, 2022
View reviewed changes
.circleci/config.yml
Comment on lines +27 to +29
- run:
name: Install packages
command: apk add maven
Copy link
Member

@nrmancuso nrmancuso Oct 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installation of maven takes less than 5 seconds, I do not think we need custom sonar image with maven pre-installed

@nrmancuso nrmancuso requested a review from romani October 22, 2022 18:57
@sonarcloud
Copy link

sonarcloud bot commented Oct 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nrmancuso nrmancuso changed the title infra: upgrade circleci to support java 11 infra: fix build and plugin execution Oct 22, 2022
romani
romani approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge.

Agree, We do not need custom image in 2022 year, docker in circleci is quick and sonar provide docker itself

@romani romani marked this pull request as ready for review October 22, 2022 19:16
@rnveach
Copy link
Member Author

rnveach commented Oct 22, 2022

@romani
#439 (comment)

How we can prove that plugin continue to work?

This circleci run actually runs our plugin with sonar, so this is one way to test. If we could find a way, we could configure this for integration tests.

@rnveach
Copy link
Member Author

rnveach commented Oct 22, 2022

@nrmancuso Thank you so much for this.

@rnveach rnveach merged commit f77013c into checkstyle:master Oct 22, 2022
@rnveach rnveach deleted the circleci branch October 22, 2022 20:05
@rnveach rnveach mentioned this pull request Oct 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrmancuso nrmancuso nrmancuso left review comments

@romani romani romani approved these changes

Assignees

@rnveach rnveach

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rnveach @muhlba91 @nrmancuso @romani