Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of dependency to sonar-java-plugin #40

Closed
romani opened this issue Dec 18, 2016 · 3 comments
Closed

get rid of dependency to sonar-java-plugin #40

romani opened this issue Dec 18, 2016 · 3 comments
Labels
Milestone

Comments

@romani
Copy link
Member

romani commented Dec 18, 2016

this dependency is required only do smth with classloader.
We should implement this ourself.
We should not depend on this artifact at all.

marschall added a commit to marschall/sonar-checkstyle that referenced this issue Feb 7, 2017
As a first step towards fixing checkstyle#40 reduce the dependency from
sonar-java-plugin to java-squid.
marschall added a commit to marschall/sonar-checkstyle that referenced this issue Feb 8, 2017
As a first step towards fixing checkstyle#40 reduce the dependency from
sonar-java-plugin to java-squid.
marschall added a commit to marschall/sonar-checkstyle that referenced this issue Feb 14, 2017
Issue checkstyle#40: get rid of dependency to sonar-java-plugin and only depend on java-squid
@romani romani added the approved label Mar 8, 2019
@romani
Copy link
Member Author

romani commented Apr 15, 2019

@muhlba91,

Unfortunately, I don't get exactly what important pieces it extracts and I quickly skimmed through it's code as well as JavaClasspath which it utilizes to see how we could easily duplicate this ode

Checkstyle should not rely on class path. There were few Checks that tried usage of class path, but such implementation endup very problatic and unstable, so we removed it. But looks like plugin tried to address this problem of classpath, BUT it is not supported feature of checkstyle.

There are few Checks still use classpath, but they will work fine without it, as they do in other plugins.

Usage of such plugin might be a reason why users report no action at non Java files #207 . Checkstyle plugin should not use classpath and should be able to process non-java files.

@romani
Copy link
Member Author

romani commented Jan 22, 2020

@muhlba91 ,

checkstyle completely disabled any class path activity in all checks. There still such methods in Checker/Treewalker but they do nothing in core library and only exists for compatibility for some time. Will be completely removed ones maven checkstyle plugin is released after 3.1.0 .

Sonar plugin completely ok to drop any features related to classpath and remove this dependency to plugin.

romani pushed a commit that referenced this issue Oct 21, 2022
@romani romani added this to the 10.3.3 milestone Oct 21, 2022
@romani
Copy link
Member Author

romani commented Oct 21, 2022

Fix is merged

@romani romani closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant