-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figureout requirements by api and jdk and other dependecies #39
Milestone
Comments
romani
changed the title
Figureout requirements by api and jdk
Figureout requirements by api and jdk and other dependecies
Dec 18, 2016
romani
added a commit
that referenced
this issue
Dec 18, 2016
romani
added a commit
that referenced
this issue
Dec 18, 2016
romani
added a commit
that referenced
this issue
Dec 18, 2016
romani
added a commit
that referenced
this issue
Dec 18, 2016
but checkstyle is jdk 8 !!!
shaded checkstyle is also jdk 8:
So we have mix of java versions in our plugin. We should upgrade to jdk8. |
romani
added a commit
that referenced
this issue
Dec 18, 2016
moved to #40 |
all required investigation was done. All other dependencies are embedded to result plugin jar as inner jar dependencies, so they are not public dependencies:
|
tsjensen
pushed a commit
to checkstyle-addons/sonar-checkstyle
that referenced
this issue
Mar 21, 2019
tsjensen
pushed a commit
to checkstyle-addons/sonar-checkstyle
that referenced
this issue
Mar 21, 2019
…urce.sslr-squid-bridge
tsjensen
pushed a commit
to checkstyle-addons/sonar-checkstyle
that referenced
this issue
Mar 21, 2019
tsjensen
pushed a commit
to checkstyle-addons/sonar-checkstyle
that referenced
this issue
Mar 21, 2019
tsjensen
pushed a commit
to checkstyle-addons/sonar-checkstyle
that referenced
this issue
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sonar 4.5.4 - jdk 1.6 munimum
Sonar 5.6 - jdk 1.8 minimum
Checkstyle 7.X - jdk 1.8 minimum
Checkstyle-sonar-plugin 3.1 is using 4.5.2 ( https://github.com/checkstyle/sonar-checkstyle/blob/master/pom.xml#L89 ) api but require jdk 1.8
What for we depend on sonar-java-plugin ?
https://github.com/checkstyle/sonar-checkstyle/blob/master/checkstyle-sonar-plugin/pom.xml#L52
This also need to be declared to user.
All test dependencies should be grouped at the end.
As we depend on sonar and checkstyle, we should depend on this two version. If some other dependencies have diffrent version that are provided by sonar, we should make comment on this.
http://www.sonarqube.org/sonar-ecosystem-upgrades-to-java-8/
http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0
http://www.sonarqube.org/downloads/
The text was updated successfully, but these errors were encountered: