Rename INTERVALS.major to INTERVALS.common #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbrunel
requested changes
Sep 19, 2017
src/scales/scale.time.js
Outdated
| @@ -261,7 +261,7 @@ function determineUnit(minUnit, min, max, capacity) { | |||
| interval = INTERVALS[UNITS[i]]; | |||
| factor = interval.steps ? interval.steps[interval.steps.length - 1] : MAX_INTEGER; | |||
|
|
|||
| if (Math.ceil((max - min) / (factor * interval.size)) <= capacity) { | |||
| if (Math.ceil((max - min) / (factor * interval.size)) <= capacity && INTERVALS[UNITS[i]].common) { | |||
There was a problem hiding this comment.
Better to reuse the previous object access and check a boolean before calling Math.ceil:
if (interval.common && Math.ceil((max - m...
There was a problem hiding this comment.
good call. i've updated it
benmccann
force-pushed
the
common-units
branch
from
6078b94 to
49708cd
Compare
simonbrunel
approved these changes
Sep 19, 2017
yofreke
pushed a commit
to yofreke/Chart.js
that referenced
this pull request
Dec 30, 2017
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses only common units for both minor and major ticks. The
Intervals.majorvariable indicated if a given unit was eligible to be a major unit. The reason we skipped quarters and weeks is that they were uncommon units. It's very strange to plotweek 26 2017,week 27 2017,week 28 2017, etc. People are much more used to seeing days or months, so we should choose one of those units. Skipping these two strange units isn't specific to just major ticks