-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Make ranges for tick auto generation configurable #4644
Comments
The ticker first grid line should be fixed in #4545, I don't know about the Q3 positioning |
Not fixed by #4545, just retested :( |
You right, #4545 fixed it only for the case of |
#4117 seems to take care of the line formatting: http://jsfiddle.net/andig2/vLgosao7/ but introduces two new problems (I can migrate this comment there):
|
the implementation is gonna change and I can assure you it's gonna enable you to change the look of the first horizontal gridLine |
Figured that one out. Its actually correct- middle of the year is the start of the third quarter. It just looks very weird, more so since q2 and q4 are not displayed. Imho this "quarter style" default formatting is more confusing than helpful? |
ping @simonbrunel |
@andig we should maybe provide a way to customize the available ranges for tick auto generation. |
Sounds like a good idea, updated title |
The first gridline problem is btw also noticable in the time scale point data example. |
Thicker first grid line - Fixed by #4700. Quater style labels - Fixed by #4777 skipping quarters and weeks during the auto tick generation. Because this fiddle is using the master build, now you will see ticks at a 3-month interval with Mar, Jun, Sep and Dec when you make the window larger. If |
This is somewhat true today. It will align the first major label. To align all of them we need #6274 |
This is against master (with or without #4545)- notice the Q3 in the middle of the year as well as the thicker first gridline:
Here's the associated fiddle: http://jsfiddle.net/andig2/sexq35rn/2/
Looks like an issue with determiniNotice that depends on width of the chart. Maybe the behaviour should already be addressed by any of the open PRs?
The text was updated successfully, but these errors were encountered: