Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Make ranges for tick auto generation configurable #4644

Closed
andig opened this issue Aug 11, 2017 · 13 comments
Closed

Feature: Make ranges for tick auto generation configurable #4644

andig opened this issue Aug 11, 2017 · 13 comments

Comments

@andig
Copy link
Contributor

andig commented Aug 11, 2017

This is against master (with or without #4545)- notice the Q3 in the middle of the year as well as the thicker first gridline:

screen shot 2017-08-11 at 16 29 32

Here's the associated fiddle: http://jsfiddle.net/andig2/sexq35rn/2/

Looks like an issue with determiniNotice that depends on width of the chart. Maybe the behaviour should already be addressed by any of the open PRs?

@simonbrunel
Copy link
Member

The ticker first grid line should be fixed in #4545, I don't know about the Q3 positioning

@andig
Copy link
Contributor Author

andig commented Aug 11, 2017

Not fixed by #4545, just retested :(

@simonbrunel
Copy link
Member

You right, #4545 fixed it only for the case of options.offset === gridLines.offsetGridLines

@simonbrunel
Copy link
Member

Might be fixed by #4117 then :) (@Zamaroth is about to rewrite it)

@andig
Copy link
Contributor Author

andig commented Aug 11, 2017

#4117 seems to take care of the line formatting: http://jsfiddle.net/andig2/vLgosao7/ but introduces two new problems (I can migrate this comment there):

  • gridline formatting is bc break with current implementation (y axes in the example), this might be fixable by looking at the docs
  • doesn't respect min/max settings on the x axis

@Zamaroth
Copy link

Zamaroth commented Aug 11, 2017

the implementation is gonna change and I can assure you it's gonna enable you to change the look of the first horizontal gridLine

@andig
Copy link
Contributor Author

andig commented Aug 12, 2017

I don't know about the Q3 positioning

Figured that one out. Its actually correct- middle of the year is the start of the third quarter. It just looks very weird, more so since q2 and q4 are not displayed. Imho this "quarter style" default formatting is more confusing than helpful?

@andig
Copy link
Contributor Author

andig commented Aug 16, 2017

ping @simonbrunel

@simonbrunel
Copy link
Member

@andig we should maybe provide a way to customize the available ranges for tick auto generation.

@andig andig changed the title Time scale: tick labelling and gridline styling odd Feature: Make ranges for tick auto generation configurable Aug 17, 2017
@andig
Copy link
Contributor Author

andig commented Aug 17, 2017

Sounds like a good idea, updated title

@andig
Copy link
Contributor Author

andig commented Aug 21, 2017

The first gridline problem is btw also noticable in the time scale point data example.

@nagix
Copy link
Contributor

nagix commented May 24, 2019

Thicker first grid line - Fixed by #4700.

Quater style labels - Fixed by #4777 skipping quarters and weeks during the auto tick generation. Because this fiddle is using the master build, now you will see ticks at a 3-month interval with Mar, Jun, Sep and Dec when you make the window larger. If ticks.major.enabled is set to true, ticks will be aligned to the beginning of year like 2015, Apr, Jul and Oct.

@nagix nagix closed this as completed May 24, 2019
@benmccann
Copy link
Contributor

If ticks.major.enabled is set to true, ticks will be aligned to the begging of year like 2015, Apr, Jul and Oct.

This is somewhat true today. It will align the first major label. To align all of them we need #6274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants