Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not export dispatch, just use getindex #22

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Do not export dispatch, just use getindex #22

merged 1 commit into from
Mar 17, 2021

Conversation

charleskawczynski
Copy link
Owner

@charleskawczynski charleskawczynski commented Mar 17, 2021

Closes #21. I'm not going to deprecate dispatch, since we're still pretty early in dev (despite this being a breaking change 😬 ).

@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #22 (87ee411) into main (ca95935) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           62        63    +1     
=========================================
+ Hits            62        63    +1     
Impacted Files Coverage Δ
src/DispatchedTuples.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca95935...87ee411. Read the comment docs.

@charleskawczynski
Copy link
Owner Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 17, 2021

@bors bors bot merged commit 047c1db into main Mar 17, 2021
@bors bors bot deleted the ck/rm_dispatch branch March 17, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we not export dispatch and externally rely on getindex(dtup, i) = dispatch(dtup, i)?
1 participant