Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we not export dispatch and externally rely on getindex(dtup, i) = dispatch(dtup, i)? #21

Closed
charleskawczynski opened this issue Mar 17, 2021 · 4 comments · Fixed by #22
Labels
question Further information is requested

Comments

@charleskawczynski
Copy link
Owner

No description provided.

@charleskawczynski charleskawczynski added the question Further information is requested label Mar 17, 2021
@ali-ramadhan
Copy link
Collaborator

Not sure if there are any limitations but when using DispatchedTuples.jl I only use getindex via e.g. dtup[Foo()] and never the dispatch function, which might actually have an overly vague/generic name?

@charleskawczynski
Copy link
Owner Author

True, true. Let's do it.

@charleskawczynski
Copy link
Owner Author

I just remembered that I was interested in nesting DispatchedTuples, which is supported through this implementation. I'm wondering if this syntax still makes sense, since it then looks like a multidimensional array 🤔

@charleskawczynski
Copy link
Owner Author

I think it should be fine 🤷🏻‍♂️

@bors bors bot closed this as completed in 047c1db Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants