Fix an ALA bug due to a missing dsiEqualDMaps overload

modules/internal/ArrayViewRankChange.chpl

@@ -119,6 +119,10 @@ module ArrayViewRankChange {
               this.idx == that.idx &&
               this.downDist.dsiEqualDMaps(that.downDist));
     }
+
+    proc dsiEqualDMaps(that) {
+      return false;
+    }
   }
 
   private proc downDomType(param rank : int,

test/optimizations/autoLocalAccess/rankChangeDynamic.chpl

@@ -0,0 +1,18 @@
+use BlockDist;
+var BaseArr = blockDist.createArray({1..2, 1..7}, int);
+
+ref RankChangeViewLocal = BaseArr[1, ..];
+ref RankChangeViewRemote = BaseArr[2, ..];
+
+const Dom = {1..7};
+
+forall i in Dom {
+  RankChangeViewLocal[i] = i;
+}
+
+// this should fail the dynamic check
+forall i in Dom {
+  RankChangeViewRemote[i] = i;
+}
+
+writeln(BaseArr);

test/optimizations/autoLocalAccess/rankChangeDynamic.compopts

@@ -0,0 +1 @@
+-slogAllArrEltAccess

test/optimizations/autoLocalAccess/rankChangeDynamic.good

@@ -0,0 +1,29 @@
+
+Start analyzing forall (rankChangeDynamic.chpl:9)
+| Found loop domain (rankChangeDynamic.chpl:7)
+| Will attempt static and dynamic optimizations (rankChangeDynamic.chpl:9)
+|
+|  Start analyzing call (rankChangeDynamic.chpl:10)
+|   Can't determine the domain of access base (rankChangeDynamic.chpl:4)
+|  This call is a dynamic optimization candidate (rankChangeDynamic.chpl:10)
+|
+End analyzing forall (rankChangeDynamic.chpl:9)
+
+
+Start analyzing forall (rankChangeDynamic.chpl:14)
+| Found loop domain (rankChangeDynamic.chpl:7)
+| Will attempt static and dynamic optimizations (rankChangeDynamic.chpl:14)
+|
+|  Start analyzing call (rankChangeDynamic.chpl:15)
+|   Can't determine the domain of access base (rankChangeDynamic.chpl:5)
+|  This call is a dynamic optimization candidate (rankChangeDynamic.chpl:15)
+|
+End analyzing forall (rankChangeDynamic.chpl:14)
+
+Static check successful. Using localAccess with dynamic check (rankChangeDynamic.chpl:10)
+Static check successful. Using localAccess with dynamic check (rankChangeDynamic.chpl:15)
+1 2 3 4 5 6 7
+1 2 3 4 5 6 7
+
+Numbers collected by prediff:
+	localAccess was called 7 times

test/optimizations/autoLocalAccess/rankChangeDynamic.numlocales

@@ -0,0 +1 @@
+2

test/optimizations/autoLocalAccess/rankChangeDynamic.prediff

@@ -0,0 +1,3 @@
+#!/bin/sh
+
+./PREDIFF-filter-accessors $1 $2 --no-this

test/optimizations/autoLocalAccess/rankChangeDynamic.skipif

@@ -0,0 +1,2 @@
+# this test's logic is wired for 2 locales
+CHPL_COMM==none

test/optimizations/autoLocalAccess/sliceDynamic.chpl

@@ -0,0 +1,19 @@
+use BlockDist;
+var BaseArr = blockDist.createArray({1..2, 1..7}, int);
+
+ref SliceViewLocal = BaseArr[1..1, ..];
+ref SliceViewRemote = BaseArr[2..2, ..];
+
+const LocalsDom = {1..1, 1..7};
+const RemotesDom = {2..2, 1..7};
+
+forall idx in LocalsDom {
+  SliceViewLocal[idx] = 1;
+}
+
+// this should fail the dynamic check
+forall idx in RemotesDom {
+  SliceViewRemote[idx] = 2;
+}
+
+writeln(BaseArr);

test/optimizations/autoLocalAccess/sliceDynamic.compopts

@@ -0,0 +1 @@
+-slogAllArrEltAccess

test/optimizations/autoLocalAccess/sliceDynamic.good

@@ -0,0 +1,29 @@
+
+Start analyzing forall (sliceDynamic.chpl:10)
+| Found loop domain (sliceDynamic.chpl:7)
+| Will attempt static and dynamic optimizations (sliceDynamic.chpl:10)
+|
+|  Start analyzing call (sliceDynamic.chpl:11)
+|   Can't determine the domain of access base (sliceDynamic.chpl:4)
+|  This call is a dynamic optimization candidate (sliceDynamic.chpl:11)
+|
+End analyzing forall (sliceDynamic.chpl:10)
+
+
+Start analyzing forall (sliceDynamic.chpl:15)
+| Found loop domain (sliceDynamic.chpl:8)
+| Will attempt static and dynamic optimizations (sliceDynamic.chpl:15)
+|
+|  Start analyzing call (sliceDynamic.chpl:16)
+|   Can't determine the domain of access base (sliceDynamic.chpl:5)
+|  This call is a dynamic optimization candidate (sliceDynamic.chpl:16)
+|
+End analyzing forall (sliceDynamic.chpl:15)
+
+Static check successful. Using localAccess with dynamic check (sliceDynamic.chpl:11)
+Static check successful. Using localAccess with dynamic check (sliceDynamic.chpl:16)
+1 1 1 1 1 1 1
+2 2 2 2 2 2 2
+
+Numbers collected by prediff:
+	localAccess was called 7 times

test/optimizations/autoLocalAccess/sliceDynamic.numlocales

@@ -0,0 +1 @@
+2

test/optimizations/autoLocalAccess/sliceDynamic.prediff

@@ -0,0 +1,3 @@
+#!/bin/sh
+
+./PREDIFF-filter-accessors $1 $2 --no-this

test/optimizations/autoLocalAccess/sliceDynamic.skipif

@@ -0,0 +1,2 @@
+# this test's logic is wired for 2 locales
+CHPL_COMM==none