Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an ALA bug due to a missing dsiEqualDMaps overload #25857

Merged

Conversation

e-kayrakli
Copy link
Contributor

@e-kayrakli e-kayrakli commented Sep 3, 2024

This PR fixes an issue exposed by llm.chpl where rank-change array views and ALA did not work well in some scenarios. These issues would cause:

$CHPL_HOME/modules/internal/ChapelAutoLocalAccess.chpl:57: In function 'chpl__ala_dynamicCheck':
$CHPL_HOME/modules/internal/ChapelAutoLocalAccess.chpl:63: error: unresolved call 'unmanaged ArrayViewRankChangeDist(unmanaged DefaultDist,3*bool,3*int(64)).dsiEqualDMaps(unmanaged DefaultDist)'

This was because a missing dsiEqualDMaps overload in the rank-change array views. The PR adds that overload, and tests that reproduced the issue.

I also confirmed that the same issue doesn't exist in slice arrayviews. I am adding a symmetric test to lock in that behavior.

Test:

  • linux64
  • gasnet

Signed-off-by: Engin Kayraklioglu <[email protected]>
Signed-off-by: Engin Kayraklioglu <[email protected]>
@e-kayrakli e-kayrakli merged commit c18eea7 into chapel-lang:main Sep 3, 2024
7 checks passed
@e-kayrakli e-kayrakli deleted the ala-rankchange-equaldmaps-fix branch September 3, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant