Fix an ALA bug due to a missing dsiEqualDMaps overload #25857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue exposed by llm.chpl where rank-change array views and ALA did not work well in some scenarios. These issues would cause:
This was because a missing
dsiEqualDMaps
overload in the rank-change array views. The PR adds that overload, and tests that reproduced the issue.I also confirmed that the same issue doesn't exist in slice arrayviews. I am adding a symmetric test to lock in that behavior.
Test: