-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sort.keyComparator
for specifying a comparator with key
#25852
Merged
+183
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
jabraham17
force-pushed
the
add-keyComparator
branch
from
September 3, 2024 18:11
49e405e
to
a9d6d98
Compare
lydia-duncan
reviewed
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have error message nits given how things appear in the test updates
test/library/standard/Sort/errors/errors-comparator.keyandcompare.good
Outdated
Show resolved
Hide resolved
test/library/standard/Sort/errors/errors-comparator.keyandkeypart.good
Outdated
Show resolved
Hide resolved
test/library/standard/Sort/errors/errors-comparator.compareargs.good
Outdated
Show resolved
Hide resolved
test/library/standard/Sort/errors/errors-comparator.keyargs.good
Outdated
Show resolved
Hide resolved
Signed-off-by: Jade Abraham <[email protected]>
jabraham17
force-pushed
the
add-keyComparator
branch
from
September 3, 2024 21:12
1e80f13
to
2c90272
Compare
Loading status checks…
…omparator special method Signed-off-by: Jade Abraham <[email protected]>
jabraham17
force-pushed
the
add-keyComparator
branch
from
September 3, 2024 21:16
734f5f1
to
c87f508
Compare
lydia-duncan
approved these changes
Sep 3, 2024
ShreyasKhandekar
added a commit
to ShreyasKhandekar/chapel
that referenced
this pull request
Sep 18, 2024
Update the sort module documentation based on the work done in the sort module stabilization subteam. On a high level - Added a short intro with a few examples of using `proc sort`, before this change it was a bit wierd to just see Comparators as the first thing in the sort module docs. - Edited the comparators section to mention the new prescribed way to create and use custom comparators using the newly created interfaces. - Went over the rest of the doc to update other things that have changed like argument names This includes work done in the following PRs: chapel-lang#25863 chapel-lang#25852 chapel-lang#25821 chapel-lang#25817 chapel-lang#25813 chapel-lang#25807 chapel-lang#25705 chapel-lang#25703 chapel-lang#25699 chapel-lang#25698 chapel-lang#25586 Signed-off-by: Shreyas Khandekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
keyComparator
interface to the Sort module. This deprecates the old way of defining comparators withkey
methods.Implements part of #25553
Testing
[Reviewed by @lydia-duncan]