Make the Sort module an official standard module #25586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
ShreyasKhandekar
approved these changes
Jul 16, 2024
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
ShreyasKhandekar
approved these changes
Jul 18, 2024
1 task
jabraham17
added a commit
that referenced
this pull request
Aug 1, 2024
Moves all of the Sort tests from their old location in `test/library/packages` to `test/library/standard`. Followup to #25586 - [x] Tested with a full paratest with/without comm [Reviewed by @ShreyasKhandekar]
ShreyasKhandekar
added a commit
to ShreyasKhandekar/chapel
that referenced
this pull request
Sep 18, 2024
Update the sort module documentation based on the work done in the sort module stabilization subteam.
On a high level
- Added a short intro with a few examples of using `proc sort`, before this change it was a bit wierd to just see Comparators as the first thing in the sort module docs.
- Edited the comparators section to mention the new prescribed way to create and use custom comparators using the newly created interfaces.
- Went over the rest of the doc to update other things that have changed like argument names
This includes work done in the following PRs:
chapel-lang#25863
chapel-lang#25852
chapel-lang#25821
chapel-lang#25817
chapel-lang#25813
chapel-lang#25807
chapel-lang#25705
chapel-lang#25703
chapel-lang#25699
chapel-lang#25698
chapel-lang#25586
Signed-off-by: Shreyas Khandekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the Sort module an official standard module. This should not be a user facing change as package modules and standard modules mostly differ in name only. However, there are changes to the online documentation. This PR adds a blank Sort page to the old location so that there will be no dead doc links as a result of this change.
Docs page:
Resolves #25083
Testing
[Reviewed by @ShreyasKhandekar]