Conditionally enable PCI in hwloc #25839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-locale support for multiple NICs and GPUs requires PCI support in hwloc. Previously, PCI support was only enabled if CHPL_COMM==ofi, which was tested in the third-party/hwloc/Makefile. Unfortunately, this meant it wasn't embedded in the build path, so that changing CHPL_COMM required manually rebuilding hwloc, which was obviously error-prone. Now PCI enable/disable is controlled by the CHPL_HWLOC_PCI variable which is embedded in the build paths for both the runtime and third-party/hwloc, and whose default value is determined by CHPL_COMM, CHPL_LOCALE_MODEL, and CHPL_GPU. Signed-off-by: John H. Hartman <[email protected]>
Signed-off-by: John H. Hartman <[email protected]>
Signed-off-by: John H. Hartman <[email protected]>
Signed-off-by: John H. Hartman <[email protected]>
jabraham17
approved these changes
Aug 29, 2024
Signed-off-by: John H. Hartman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-locale support for multiple NICs and GPUs requires PCI support in
hwloc.Previously, PCI support was only enabled if
CHPL_COMM==ofi, which was testedin the
third-party/hwloc/Makefile. Unfortunately, this meant it wasn'tembedded in the build path, so that changing
CHPL_COMMrequired manuallyrebuilding
hwloc, which was obviously error-prone. Now PCI enable/disable iscontrolled by the
CHPL_HWLOC_PCIvariable which is embedded in the buildpaths for both the runtime and
third-party/hwloc, and whose default value isdetermined by
CHPL_COMM,CHPL_LOCALE_MODEL, andCHPL_GPU.Signed-off-by: John H. Hartman [email protected]