Extra warning about Requires.private in builds using HWLOC_PCI=enable
#26002
Comments
jabraham17
added a commit
that referenced
this issue
Sep 30, 2024
…26008) Tightens up the logic for when we should warn about 'Requires.private' (and also 'Requires'). We only need to warn when the compiler/linker flags are not already handled by 'Cflags'/`Libs`. Details: `Requires`/`Requires.private` list what other pkg-config libraries are needed, so that `pkg-config` can pull in the need dependencies/flags. This ends up being a recursive operation (i.e. 'A' has 'Requires: B', so we must process 'B.pc'). But if we already have the information needed, this is unnecessary. So if we have 'Requires: B', but 'B' is already listed in 'Libs', then for our purposes we have satisfied the 'Requires.' Our simple pkg-config parser is used only for bundled third-party libs, and we do not need to ability to recursively search other .pc files to satisfy the requirements. So this PR uses the above logic to avoid warning about `Requires`/`Requires.private` not being handled This should resolve #26002 [Reviewed by @mppf and @jhh67]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since #25839, if
CHPL_HWLOC_PCI=enablethenprintchplenv --internalreports the following warningThis occurs frequently in the build output of
make, asprintchplenvis invoked frequently. While this warning does not seem to impact correctness, it does clutter the output ofmakeandprintchplenv.This affects many configs, although not the default.
CHPL_HWLOC_PCI=enableis the default with multi-locale support or gpu supportIt may be the correct solution is to just silence the warning, although maybe we can just properly handle
Requires.privatein our simple pkg-config parserThe text was updated successfully, but these errors were encountered: