Upgrade Arkouda release testing from 1.30 to 1.31 #22669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See Bears-R-Us/arkouda#2552 and Bears-R-Us/arkouda#2551 Signed-off-by: Ben McDonald <[email protected]>
|
Remove code to set llvm version for 1.30 from the release scripts? |
Signed-off-by: Ben McDonald <[email protected]>
ronawho
reviewed
Jul 5, 2023
| if [ -f /cy/users/chapelu/setup_system_llvm.bash ] ; then | ||
| source /cy/users/chapelu/setup_system_llvm.bash 11 | ||
| source /cy/users/chapelu/setup_system_llvm.bash 15 |
Signed-off-by: Ben McDonald <[email protected]>
ronawho
approved these changes
Jul 5, 2023
|
Just wanted to note the code setting LLVM version for release testing is not strictly needed anymore with Chapel 1.31, since the newest (default) LLVM on the test systems is supported by 1.31. (This wasn't the case for 1.30 after updating test systems to LLVM 15.) However, it might still be good to have this manual setting (as you did) so this config is resilient against something like a system being upgraded to LLVM 16 before we support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Bears-R-Us/arkouda#2552 and Bears-R-Us/arkouda#2551