Closes #2550: Drop support for Chapel 1.29 #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcdonald3
added a commit
to bmcdonald3/chapel
that referenced
this pull request
Jul 5, 2023
See Bears-R-Us/arkouda#2552 and Bears-R-Us/arkouda#2551 Signed-off-by: Ben McDonald <[email protected]>
bmcdonald3
added a commit
to chapel-lang/chapel
that referenced
this pull request
Jul 5, 2023
stress-tess
requested changes
Jul 6, 2023
There was a problem hiding this comment.
The only thing I have is we should revisit the compat modules and remove any that we only had because differences of 1.29 (i.e. where the e-130 and gt-130 version are the same). I didn't look terribly close but I think these might be a few
ArkoudaArrayCompatArkoudaBlockCompatArkoudaFileCompatArkoudaMapCompatArkoudaRegexCompat
This was referenced Jul 6, 2023
|
Just noting that per our SOP on updating supported Chapel versions, this should not be merged until a week after the 1.31 support is added. |
|
I think we have been supporting Chapel 1.31 since the Chapel release that was on June 22nd (2 weeks ago), it just hasn't been in the CI, but we have been testing it in nightly testing. |
stress-tess
approved these changes
Jul 10, 2023
Now that Chapel 1.31 has been released, Chapel version 1.29 is no longer supported by Arkouda.
Ethan-DeBandi99
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Chapel 1.31 has been released, Chapel version 1.29 is no longer supported by Arkouda.
Closes #2550