Ranged weapon updates and DDA fixes

So it turns out a long-forgotten side effect of CleverRaven/Cataclysm-DDA#21545 was breaking the janky hardcoded injection of certain flags and ammo effects into

cataclysmbnteam/Cataclysm-BN#1857 makes this more important in BN but implemented same general changes to both versions in case DDA ever notices that function (and it's been about 5 years so literally everyone evidently never noticed any changes to crossbow behavior).

Also updated the deployable vehicles in DDA version, as CleverRaven/Cataclysm-DDA#59572 updated folding vehicles. While a great idea on paper, in practice they somehow managed to invent a form of JSON that's even MORE of an unreadable mess than vehicle JSON is, with making folded_parts something you have to work with to implement deployable vehicles now.

MST_Extra/items/ranged.json

@@ -20,7 +20,7 @@
     "durability": 6,
     "clip_size": 1,
     "reload": 100,
-    "flags": [ "RELOAD_AND_SHOOT", "NEVER_JAMS", "PRIMITIVE_RANGED_WEAPON" ],
+    "flags": [ "WATERPROOF_GUN", "RELOAD_AND_SHOOT", "NEVER_JAMS", "PRIMITIVE_RANGED_WEAPON" ],
     "pocket_data": [ { "pocket_type": "MAGAZINE", "ammo_restriction": { "atlatl": 1 } } ]
   },
   {
@@ -48,6 +48,6 @@
     "pocket_data": [ { "pocket_type": "MAGAZINE", "ammo_restriction": { "bolt": 1 } } ],
     "reload": 300,
     "valid_mod_locations": [ [ "underbarrel", 1 ], [ "sights", 1 ], [ "accessories", 2 ] ],
-    "flags": [ "PRIMITIVE_RANGED_WEAPON" ]
+    "flags": [ "WATERPROOF_GUN", "NEVER_JAMS", "PRIMITIVE_RANGED_WEAPON" ]
   }
 ]

MST_Extra/items/tools.json

@@ -84,11 +84,10 @@
     "volume": "11250 ml",
     "bashing": 10,
     "to_hit": -5,
-    "use_action": {
-      "type": "unfold_vehicle",
-      "vehicle_name": "makeshift_sled_vehicle",
-      "unfold_msg": "You unfold and deploy the makeshift sled.",
-      "moves": 200
+    "use_action": [ "UNFOLD_GENERIC" ],
+    "variables": {
+      "vehicle_name": "Makeshift Sled",
+      "folded_parts": "[{\"id\":\"makeshift_sled_frame_part\",\"base\":{\"typeid\":\"makeshift_sled_frame_item\",\"item_tags\":[\"VEHICLE\"]},\"mount_dx\":0,\"mount_dy\":0},{\"id\":\"makeshift_sled_runner_part\",\"base\":{\"typeid\":\"makeshift_sled_runners_item\",\"item_tags\":[\"VEHICLE\"]},\"mount_dx\":0,\"mount_dy\":0},{\"id\":\"makeshift_sled_basket_part\",\"base\":{\"typeid\":\"makeshift_sled_basket_item\",\"item_tags\":[\"VEHICLE\"]},\"mount_dx\":0,\"mount_dy\":0}]"
     }
   },
   {
@@ -104,11 +103,10 @@
     "volume": "68 L",
     "bashing": 20,
     "to_hit": -10,
-    "use_action": {
-      "type": "unfold_vehicle",
-      "vehicle_name": "log_canoe_vehicle",
-      "unfold_msg": "You deploy the log canoe.",
-      "moves": 100
+    "use_action": [ "UNFOLD_GENERIC" ],
+    "variables": {
+      "vehicle_name": "Log Canoe",
+      "folded_parts": "[{\"id\":\"log_frame_part\",\"base\":{\"typeid\":\"log_frame_item\",\"item_tags\":[\"VEHICLE\"]},\"mount_dx\":0,\"mount_dy\":0},{\"id\":\"hand_paddles\",\"base\":{\"typeid\":\"hand_paddles\",\"item_tags\":[\"VEHICLE\"]},\"mount_dx\":0,\"mount_dy\":0},{\"id\":\"log_frame_part\",\"base\":{\"typeid\":\"log_frame_item\",\"item_tags\":[\"VEHICLE\"]},\"mount_dx\":0,\"mount_dy\":1},{\"id\":\"log_frame_part\",\"base\":{\"typeid\":\"log_frame_item\",\"item_tags\":[\"VEHICLE\"]},\"mount_dx\":0,\"mount_dy\":-1}]"
     }
   },
   {

MST_Extra_BN/items/ranged.json

@@ -20,7 +20,7 @@
     "durability": 6,
     "clip_size": 1,
     "reload": 100,
-    "flags": [ "RELOAD_AND_SHOOT", "NEVER_JAMS", "PRIMITIVE_RANGED_WEAPON" ]
+    "flags": [ "WATERPROOF_GUN", "RELOAD_AND_SHOOT", "NEVER_JAMS", "PRIMITIVE_RANGED_WEAPON" ]
   },
   {
     "id": "crossbow_makeshift",
@@ -46,6 +46,6 @@
     "clip_size": 1,
     "reload": 300,
     "valid_mod_locations": [ [ "underbarrel", 1 ], [ "sights", 1 ], [ "accessories", 2 ] ],
-    "flags": [ "PRIMITIVE_RANGED_WEAPON" ]
+    "flags": [ "WATERPROOF_GUN", "NEVER_JAMS", "PRIMITIVE_RANGED_WEAPON" ]
   }
 ]