Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add raw-calculated fields for more schema objects #1094

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Add raw-calculated fields for more schema objects #1094

merged 1 commit into from
Feb 13, 2023

Conversation

GeorgLink
Copy link
Member

Replaces #1070 - fixes DCO-sign-off by co-authoring the commit.

Original message:

Related to #1023

I took all the rest of the updated schema and put it into the files here. The major addition is a new "Raw/Calculated" field for the updated files :)

Co-authored-by: Matt Cantu Snell [email protected]

@GeorgLink GeorgLink mentioned this pull request Dec 30, 2022
Closed
@coveralls
Copy link

coveralls commented Dec 30, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 4164795035

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.313%
Totals Coverage Status
Change from base Build 4142859283: 0.0%
Covered Lines: 9103
Relevant Lines: 11059
💛 - Coveralls

@sduenas
Copy link
Member

sduenas commented Feb 8, 2023

Would you mind to rebase this PR?

@GeorgLink
Copy link
Member Author

Sure, how does this look?

sduenas
sduenas reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an empty new line at the end of all files?

@GeorgLink
Copy link
Member Author

Empty lines are added 👍

@GeorgLink
Copy link
Member Author

Is this ready to be merged now?

@GeorgLink @Nebrethar @sduenas
Add raw-calculated fields for more schema objects
7191a8e 
Co-authored-by: Matt Cantu Snell <[email protected]>
Signed-off-by: Georg J.P. Link <[email protected]>
@sduenas sduenas merged commit c48a36c into chaoss:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduenas sduenas sduenas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GeorgLink @coveralls @sduenas