Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git] Add schema column for raw/calculated #1023

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

GeorgLink
Copy link
Member

Provide additional information where data in the schema originally comes
from and what was tool was used to enrich it.

Sort fields alphabetically.

This is only for the git index. I would open additional PRs for other indexes as well.

@GeorgLink GeorgLink force-pushed the schema-raw-calculated branch from b3e559e to d8d7b68 Compare January 19, 2022 20:06
@GeorgLink
Copy link
Member Author

Force pushed updated commit message with my DCO sign-off

@coveralls
Copy link

coveralls commented Jan 19, 2022

Pull Request Test Coverage Report for Build 1741592303

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.944%

Totals Coverage Status
Change from base Build 1741306234: 0.0%
Covered Lines: 8768
Relevant Lines: 10700

💛 - Coveralls

@zhquan zhquan self-requested a review January 21, 2022 10:41
@zhquan
Copy link
Member

zhquan commented Jan 21, 2022

@GeorgLink thanks for the PR

If this PR is only for git, could you add [git] ..... on the title?

@GeorgLink GeorgLink changed the title Add schema column for raw/calculated [git] Add schema column for raw/calculated Jan 21, 2022
@GeorgLink
Copy link
Member Author

Done

@zhquan
Copy link
Member

zhquan commented Jan 21, 2022

Sorry I was not clear, I mean the title of the commit message

@GeorgLink GeorgLink force-pushed the schema-raw-calculated branch from d8d7b68 to 885cab3 Compare January 24, 2022 14:08
@GeorgLink
Copy link
Member Author

Done, this time I updated the commit title 💯

@zhquan
Copy link
Member

zhquan commented Jan 24, 2022

@GeorgLink the last thing.
Could you rebase it and I will merge it. Thanks.

This branch is 1 commit ahead, 2 commits behind master.

Provide additional information where data in the schema originally comes
from and what was tool was used to enrich it.

Sort fields alphabetically.

Signed-off-by: Georg J.P. Link <[email protected]>
@GeorgLink GeorgLink force-pushed the schema-raw-calculated branch from 885cab3 to e3ce678 Compare January 24, 2022 18:46
@GeorgLink
Copy link
Member Author

How does this look to you?

Copy link
Member

@zhquan zhquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhquan zhquan closed this in fda45e9 Jan 25, 2022
@zhquan zhquan merged commit fda45e9 into master Jan 25, 2022
@sduenas sduenas deleted the schema-raw-calculated branch October 17, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants